Skip to content

fix(BeyondTrust): add missing provider field to integration YAML#43876

Merged
DanielTal87 merged 2 commits intomasterfrom
fix/beyondtrust-add-provider-field
Apr 14, 2026
Merged

fix(BeyondTrust): add missing provider field to integration YAML#43876
DanielTal87 merged 2 commits intomasterfrom
fix/beyondtrust-add-provider-field

Conversation

@DanielTal87
Copy link
Copy Markdown
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Description

Must have

  • Tests
  • Documentation

@DanielTal87 DanielTal87 requested a review from kamalq97 April 14, 2026 13:47
@DanielTal87 DanielTal87 self-assigned this Apr 14, 2026
@DanielTal87 DanielTal87 requested a review from Shir2611 April 14, 2026 13:47
@content-bot
Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/BeyondTrust/Integrations/BeyondTrustPrivilegeManagementCloud
   BeyondTrustPrivilegeManagementCloud.py2203185%128, 130, 304–305, 308–309, 350, 368, 478–479, 481–485, 487, 490–491, 493–498, 501–503, 505–508
TOTAL2203185% 

Tests Skipped Failures Errors Time
39 0 💤 0 ❌ 0 🔥 2.961s ⏱️

@DanielTal87
Copy link
Copy Markdown
Contributor Author

@marketplace-ai-reviewer start review

@DanielTal87 DanielTal87 added docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines skip-ai-review labels Apr 14, 2026
@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

Copy link
Copy Markdown
Contributor

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to the BeyondTrust pack! I've reviewed the PR and found a few minor metadata and structural adjustments needed before we can merge.

Specifically, the integration YAML needs to be updated to follow Event Collector standards (such as using isFetchEvents and defining the correct marketplaces), and the root keys need to be reordered. Additionally, the pack metadata requires a few missing fields like the creation date and Cortex URL, and the release notes should be adjusted to the pack level since these are metadata improvements.

Let me know if you have any questions!

Additionally, please address the following file-level notes:

  • Packs/BeyondTrust/Integrations/BeyondTrustPrivilegeManagementCloud/BeyondTrustPrivilegeManagementCloud.yml: - The first key defined at the root level of the .yml file must always be name or display. Currently, the file starts with commonfields. Please reorder the keys so that name or display is at the very top.
  • Since this is an Event Collector integration (isfetchevents: true), the marketplaces array must explicitly contain both marketplacev2 and platform in the integration .yml file. Please add the marketplaces array to the root level of this file.
  • Event collectors must configure the isFetchEvents parameter instead of isFetch. Please rename the isFetch parameter in the configuration section to isFetchEvents.
  • Packs/BeyondTrust/pack_metadata.json: - The url field must be updated to https://www.paloaltonetworks.com/cortex.
  • The mandatory key created is missing from the pack metadata.
  • The vendor name (BeyondTrust) must be added to the keywords list.

@Shir2611, @kamalq97, @DanielTal87 please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Comment thread Packs/BeyondTrust/ReleaseNotes/1_0_2.md
@DanielTal87 DanielTal87 enabled auto-merge (squash) April 14, 2026 14:19
@content-bot
Copy link
Copy Markdown
Contributor

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@DanielTal87 DanielTal87 merged commit d6c8b09 into master Apr 14, 2026
44 of 51 checks passed
@DanielTal87 DanielTal87 deleted the fix/beyondtrust-add-provider-field branch April 14, 2026 15:11
mcvic1rj pushed a commit to mcvic1rj/xsoar-content that referenced this pull request Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants