Skip to content

remove old supported modules from PreProcessRule#43937

Merged
Shir2611 merged 9 commits into
masterfrom
cleanup-invalid-license-PreProcessRule
May 18, 2026
Merged

remove old supported modules from PreProcessRule#43937
Shir2611 merged 9 commits into
masterfrom
cleanup-invalid-license-PreProcessRule

Conversation

@Shir2611
Copy link
Copy Markdown
Contributor

@Shir2611 Shir2611 commented Apr 19, 2026

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: CIAC-15886

Description

remove old supported modules from PreProcessRule
the old supported modules
cloud_posture
cloud
cloud_runtime_security
edr
xsoar
asm
tim
cloud_appsec
exposure_management email_security

MATCH (c:PreProcessRule) WHERE ANY( m IN c.supportedModules WHERE m IN ["cloud_posture", "cloud", "cloud_runtime_security", "edr", "xsoar", "asm", "tim", "cloud_appsec", "exposure_management", "email_security", "agentix", "xsiam"] ) RETURN c.name AS classifier_name, c.supportedModules AS supported_modules ORDER BY c.name

Must have

  • Tests
  • Documentation

@Shir2611 Shir2611 requested a review from BEAdi April 19, 2026 12:48
@Shir2611 Shir2611 self-assigned this Apr 19, 2026
@Shir2611 Shir2611 added docs-approved bypass.url Whether to create build bucket, add this label for marketplace.bootstrap.bypass.url ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines supported-modules-approved ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Apr 19, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 19, 2026

Your contributed Gem pack has been modified on files:

Packs/Gem/pack_metadata.json
Packs/Gem/PreProcessRules/preprocessrule-d9268047-fccf-4e63-8856-37a2fbbe722b-Gem_Alert_Merger.json
Packs/Gem/ReleaseNotes/1_0_11.md
Please review the changes here

@content-bot
Copy link
Copy Markdown
Contributor

content-bot commented Apr 19, 2026

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Apr 20, 2026
@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

marketplace-ai-reviewer commented Apr 20, 2026

🤖 Analysis started. Please wait for results...

@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

marketplace-ai-reviewer commented Apr 20, 2026

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

marketplace-ai-reviewer
marketplace-ai-reviewer reviewed Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting your PR!
Before moving on with the detailed review, please take a moment to address the following general comments.

  • The PR title and description mention removing old supported modules, but the actual changes only add the marketplaces field to PreProcessRules. Please update the PR title and description to accurately reflect the addition of the marketplaces field, or verify that the intended removals were actually committed.

@Shir2611 Shir2611 added the ForceMerge Forcing the merge of the PR despite the build status label Apr 27, 2026
@Shir2611
Copy link
Copy Markdown
Contributor Author

Shir2611 commented Apr 27, 2026

force merge as part of an effort of removing all old supported modules

@Shir2611 Shir2611 added se-approved Pack available in SE and removed se-approved Pack available in SE labels Apr 27, 2026
@content-bot

This comment has been minimized.

Sign in to view
@content-bot

This comment has been minimized.

Sign in to view
@content-bot

This comment has been minimized.

Sign in to view
@content-bot

This comment has been minimized.

Sign in to view
@content-bot
Copy link
Copy Markdown
Contributor

content-bot commented May 18, 2026

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@content-bot
Copy link
Copy Markdown
Contributor

content-bot commented May 18, 2026

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: success
Report ID: 4724402e4e2fec48

📋 Triage Report

⚠️ AI-generated triage. Validate before acting.

@Shir2611 Shir2611 merged commit 908e4e9 into master May 18, 2026
22 of 23 checks passed
@Shir2611 Shir2611 deleted the cleanup-invalid-license-PreProcessRule branch May 18, 2026 10:41
mayyagoldman pushed a commit that referenced this pull request May 18, 2026
@Shir2611 @mayyagoldman
remove old supported modules from PreProcessRule (#43937)
dccbe28 
* remove old supported modules from PreProcessRule

* test

* revert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marketplace-ai-reviewer marketplace-ai-reviewer marketplace-ai-reviewer left review comments

@BEAdi BEAdi BEAdi approved these changes

Assignees

@Shir2611 Shir2611

Labels

bypass.url Whether to create build bucket, add this label for marketplace.bootstrap.bypass.url docs-approved ForceMerge Forcing the merge of the PR despite the build status ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines skip-ai-review supported-modules-approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Shir2611 @content-bot @marketplace-ai-reviewer @BEAdi @tcarmeli1