update by michal-dagan · Pull Request #43966 · demisto/content

michal-dagan · 2026-04-20T12:35:15Z

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

In Progress
Ready
In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/CIAC-16562

Description

Must have

Tests
Documentation

content-bot · 2026-04-20T12:36:40Z

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

@marketplace-ai-reviewer start review - Initiate a full AI code review
@marketplace-ai-reviewer re-review - Incremental review for new commits

github-actions · 2026-04-20T12:39:15Z

Coverage Report

File	Stmts	Miss	Cover	Missing
Packs/ServiceNow/Integrations/ServiceNowv2
ServiceNowv2.py	1574	278	82%	214, 226, 232, 480, 482, 486, 511, 552, 559–560, 598–599, 726–729, 739, 749–759, 770, 781–782, 854–855, 862, 868–874, 885–886, 899, 903, 916, 942, 944, 946–947, 949–950, 952–955, 957, 999, 1004, 1032–1037, 1040, 1043, 1154, 1295–1301, 1303, 1306–1307, 1309–1312, 1314, 1316–1317, 1319, 1321–1322, 1324–1325, 1327, 1350–1351, 1353, 1362–1363, 1394, 1433, 1436, 1443, 1471, 1476, 1564, 1619, 1667, 1719, 1800, 1862, 1865, 1914, 1916–1918, 1920–1921, 1962, 1965–1967, 1981, 1986–1988, 2014, 2049–2050, 2058, 2109, 2153–2156, 2158, 2161, 2168, 2231–2236, 2238–2239, 2241–2243, 2245–2246, 2248–2250, 2252–2253, 2255, 2257, 2269, 2272, 2274, 2287–2292, 2294–2295, 2297–2299, 2301–2302, 2304–2306, 2308–2309, 2311, 2323–2324, 2327, 2329, 2347, 2350, 2378, 2381, 2415, 2418, 2422, 2450, 2490, 2516, 2546, 2644, 2656, 2667, 2670, 2674–2675, 2679, 2681–2682, 2754, 2760, 2771, 2819–2820, 2861–2864, 2886–2887, 2891–2892, 2927, 2931, 2937, 3029, 3032–3034, 3165–3169, 3171–3172, 3176–3177, 3232–3233, 3259, 3397, 3399, 3403–3404, 3579–3581, 3587, 3604, 3607, 3611, 3642, 3722, 3748–3749, 3754, 3770, 3791, 3812–3814, 3833–3835, 3877, 3885, 3941–3943, 3945, 3947, 3949, 3951, 3953, 3955, 3957, 3959, 3963, 3965, 3967, 3969–3970, 3975–3976, 3984
TOTAL	1574	278	82%

Tests	Skipped	Failures	Errors	Time
180	0 💤	0 ❌	0 🔥	27523485m 6s ⏱️

marketplace-ai-reviewer · 2026-04-20T13:10:58Z

🤖 Analysis started. Please wait for results...

marketplace-ai-reviewer · 2026-04-20T13:16:49Z

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

marketplace-ai-reviewer

Thanks for your contribution to the ServiceNow integration! I've reviewed the PR and left a few notes to help polish the code.

Mainly, please guard against potential TypeErrors when accessing the name key during file operations, and ensure your release notes start with an approved prefix. There are also a couple of minor test file adjustments to make, such as moving an import to the top and adding a unit test for path sanitization.

Let me know if you have any questions!

Additionally, please address the following file-level notes:

Packs/ServiceNow/Integrations/ServiceNowv2/ServiceNowv2_test.py: Consider adding a unit test for the path sanitization in update_remote_system_with_entries.

@inbalapt1, @dantavori, @michal-dagan please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

michal-dagan · 2026-04-20T14:32:11Z

Addressed all AI reviewer feedback:

Added default value guard ("") to file_data.get("name", "") and path_res.get("name", "") to prevent potential TypeError
Moved import os to top of test file
Added test_update_remote_system_with_entries_uses_basename unit test for path sanitization in update_remote_system_with_entries
Updated release note in 2_9_7.md to use approved prefix: 'Fixed an issue with filename handling during file upload operations.'

@marketplace-ai-reviewer re-review

marketplace-ai-reviewer · 2026-04-20T14:41:06Z

🤖 Analysis started. Please wait for results...

marketplace-ai-reviewer · 2026-04-20T14:52:27Z

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

marketplace-ai-reviewer

🔄 Re-reviewing updates...

Important

To maintain review integrity, threads marked as Resolved without accompanying changes or explanations will be automatically unresolved for further verification.

Hi there! Thanks for your contribution to the ServiceNowv2 integration.

I've left a few notes for you to look at, primarily around safely handling None values for file names using or "" in the main code. On the testing side, please fix a TypeError related to argument counts, explicitly assert expected file names, and add coverage for missing file names.

Let me know if you have any questions!

Additionally, please address the following file-level notes:

Packs/ServiceNow/Integrations/ServiceNowv2/ServiceNowv2_test.py: Add test coverage for missing or None file names.

@inbalapt1, @dantavori, @marketplace-ai-reviewer, @michal-dagan please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

marketplace-ai-reviewer · 2026-04-20T15:51:12Z

🤖 Analysis started. Please wait for results...

marketplace-ai-reviewer · 2026-04-20T16:20:07Z

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

marketplace-ai-reviewer

🔄 Re-reviewing updates...

Important

To maintain review integrity, threads marked as Resolved without accompanying changes or explanations will be automatically unresolved for further verification.

Thank you for your contribution! Re-reviewed your PR, No new issues found. Great work! 👍
Please check the previous comments to ensure all feedback has been resolved.

@dantavori, @inbalapt1, @michal-dagan, @marketplace-ai-reviewer please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

content-bot · 2026-04-20T17:36:52Z

This PR was automatically updated by a GitHub Action

ServiceNow pack version was bumped to 2.9.8.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

content-bot · 2026-04-27T10:32:19Z

This PR was automatically updated by a GitHub Action

ServiceNow pack version was bumped to 2.9.9.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

inbalapt1

Checked.

marketplace-ai-reviewer · 2026-04-28T15:21:32Z

🤖 Analysis started. Please wait for results...

marketplace-ai-reviewer · 2026-04-28T15:22:05Z

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

marketplace-ai-reviewer

Thanks for submitting your PR!
Before moving on with the detailed review, please take a moment to address the following general comments.

The PR title and description are too generic ('update') and do not reflect the actual changes. Please update the title and description to explicitly state that this PR fixes a path traversal issue by using os.path.basename for file names in the ServiceNowv2 integration.

content-bot · 2026-04-28T16:09:19Z

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

content-bot · 2026-04-28T19:05:42Z

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: failed
Report ID: d597765c93cb2e24

📋 Triage Report
💡 Resolutions are available in the full report.

⚠️ AI-generated triage. Validate before acting.

inbalapt1 · 2026-04-29T06:58:59Z

This PR requires Force Merge because of failing TPBs that are not related to the changes here. Attaching an empty change PR with the same failures: #43741

update

20c3632

michal-dagan marked this pull request as ready for review April 20, 2026 12:35

michal-dagan requested a review from dantavori as a code owner April 20, 2026 12:35

Merge branch 'master' into fix-service-now-pentest

59f956c

michal-dagan requested review from content-bot and inbalapt1 April 20, 2026 12:38

michal-dagan added the ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines label Apr 20, 2026

Merge branch 'master' into fix-service-now-pentest

af53ef5

michal-dagan added the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Apr 20, 2026

marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Apr 20, 2026

marketplace-ai-reviewer reviewed Apr 20, 2026

View reviewed changes

Documentation and metadata improvements

27c4fb3

michal-dagan and others added 2 commits April 20, 2026 17:33

update

512b1b5

Merge branch 'master' into fix-service-now-pentest

848929a

marketplace-ai-reviewer reviewed Apr 20, 2026

View reviewed changes

michal-dagan added 3 commits April 20, 2026 18:21

update

e141f4e

Documentation and metadata improvements

46fbf51

update

23db7d7

michal-dagan requested a review from marketplace-ai-reviewer April 20, 2026 15:41

marketplace-ai-reviewer reviewed Apr 20, 2026

View reviewed changes

michal-dagan changed the title ~~Mythos - Pentest Evaluation Findings - ServiceNow~~ ServiceNow Apr 20, 2026

michal-dagan changed the title ~~ServiceNow~~ update Apr 20, 2026

Content Bot added 2 commits April 20, 2026 17:36

Merged master into current branch.

67156fb

Bump pack from version ServiceNow to 2.9.8.

65bbe29

michal-dagan and others added 4 commits April 23, 2026 09:11

Merge branch 'master' into fix-service-now-pentest

3d6ae66

Merge branch 'master' into fix-service-now-pentest

030f6da

Merged master into current branch.

35a4e6b

Bump pack from version ServiceNow to 2.9.9.

9a88b5b

inbalapt1 approved these changes Apr 28, 2026

View reviewed changes

Merge branch 'master' into fix-service-now-pentest

cc66f91

inbalapt1 added the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Apr 28, 2026

marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Apr 28, 2026

marketplace-ai-reviewer reviewed Apr 28, 2026

View reviewed changes

inbalapt1 added the docs-approved label Apr 29, 2026

inbalapt1 added the ForceMerge Forcing the merge of the PR despite the build status label Apr 29, 2026

dantavori approved these changes Apr 29, 2026

View reviewed changes

dantavori merged commit 50425ed into master Apr 29, 2026
41 of 50 checks passed

dantavori deleted the fix-service-now-pentest branch April 29, 2026 09:09

Conversation

michal-dagan commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contributing to Cortex XSOAR Content

Status

Related Issues

Description

Must have

Uh oh!

content-bot commented Apr 20, 2026

🤖 AI-Powered Code Review Available

Uh oh!

github-actions Bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marketplace-ai-reviewer commented Apr 20, 2026

Uh oh!

marketplace-ai-reviewer commented Apr 20, 2026

Uh oh!

marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michal-dagan commented Apr 20, 2026

Uh oh!

marketplace-ai-reviewer commented Apr 20, 2026

Uh oh!

marketplace-ai-reviewer commented Apr 20, 2026

Uh oh!

marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

🔄 Re-reviewing updates...

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marketplace-ai-reviewer commented Apr 20, 2026

Uh oh!

marketplace-ai-reviewer commented Apr 20, 2026

Uh oh!

marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

🔄 Re-reviewing updates...

Uh oh!

content-bot commented Apr 20, 2026

This PR was automatically updated by a GitHub Action

Uh oh!

content-bot commented Apr 27, 2026

This PR was automatically updated by a GitHub Action

Uh oh!

inbalapt1 left a comment

Choose a reason for hiding this comment

Uh oh!

marketplace-ai-reviewer commented Apr 28, 2026

Uh oh!

marketplace-ai-reviewer commented Apr 28, 2026

Uh oh!

marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

Uh oh!

content-bot commented Apr 28, 2026

Uh oh!

content-bot commented Apr 28, 2026

🔍 AI Triage Report Available

Uh oh!

inbalapt1 commented Apr 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

michal-dagan commented Apr 20, 2026 •

edited

Loading

github-actions Bot commented Apr 20, 2026 •

edited

Loading