Skip to content

CIAC-16564: ArgusManagedDefence improve metadata#43977

Merged
DeanArbel merged 5 commits intomasterfrom
CIAC-16560-mnemonicMDR-improve-documentation
Apr 26, 2026
Merged

CIAC-16564: ArgusManagedDefence improve metadata#43977
DeanArbel merged 5 commits intomasterfrom
CIAC-16560-mnemonicMDR-improve-documentation

Conversation

@lironcohen272
Copy link
Copy Markdown
Contributor

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-16560

Description

improve documentation ArgusManagedDefence integration

@lironcohen272 lironcohen272 added docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines skip-ai-review labels Apr 20, 2026
@content-bot
Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@github-actions
Copy link
Copy Markdown

Your contributed mnemonicMDR pack has been modified on files:

Packs/mnemonicMDR/Integrations/ArgusManagedDefence/ArgusManagedDefence_test.py
Packs/mnemonicMDR/Integrations/ArgusManagedDefence/ArgusManagedDefence.py
Packs/mnemonicMDR/pack_metadata.json
Packs/mnemonicMDR/ReleaseNotes/1_1_18.md
Please review the changes here

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 20, 2026

@content-bot
Copy link
Copy Markdown
Contributor

Validate summary
The following errors were thrown as a part of this pr: ST111, DO106.
The following errors cannot be ignored: ST111, DO106.
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.
The following errors don't run as part of the nightly flow and therefore can be force merged: ST111, DO106.

Verdict: PR can be force merged from validate perspective? ✅

@konraduh
Copy link
Copy Markdown
Contributor

Your contributed mnemonicMDR pack has been modified on files:

Packs/mnemonicMDR/Integrations/ArgusManagedDefence/ArgusManagedDefence_test.py Packs/mnemonicMDR/Integrations/ArgusManagedDefence/ArgusManagedDefence.py Packs/mnemonicMDR/pack_metadata.json Packs/mnemonicMDR/ReleaseNotes/1_1_18.md Please review the changes here

Do not merge these changes.

  • Updating the docker image breaks the integration.
  • Those imports do not exist.

@konraduh
Copy link
Copy Markdown
Contributor

Also, I was under the impression that the docker image was pinned to major version 2.

@lironcohen272
Copy link
Copy Markdown
Contributor Author

Hi @konraduh , I've reverted the Docker image update and kept the existing import.

@lironcohen272 lironcohen272 added the ForceMerge Forcing the merge of the PR despite the build status label Apr 26, 2026
@lironcohen272
Copy link
Copy Markdown
Contributor Author

lironcohen272 commented Apr 26, 2026

Partner asked to not update the docker image.

@DeanArbel DeanArbel merged commit 855e059 into master Apr 26, 2026
27 of 28 checks passed
@DeanArbel DeanArbel deleted the CIAC-16560-mnemonicMDR-improve-documentation branch April 26, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-approved ForceMerge Forcing the merge of the PR despite the build status ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants