Fix reply_urls phantom arg in msgraph-apps-service-principal-update#44147
Fix reply_urls phantom arg in msgraph-apps-service-principal-update#44147
Conversation
🤖 AI-Powered Code Review AvailableYou can leverage AI-powered code review to assist with this PR! Available Commands:
|
…demisto/content into fix-msgraph-apps-reply-urls-phantom-arg # Conflicts: # Packs/MicrosoftGraphApplications/Integrations/MicrosoftGraphApplications/README.md
|
🤖 Analysis started. Please wait for results... |
🤖 AI Review DisclaimerThis review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause. |
marketplace-ai-reviewer
left a comment
There was a problem hiding this comment.
Hi! Thanks for your contribution to the Microsoft Graph Applications pack. I've reviewed the changes and have a few quick requests to help get this ready. Please make sure to update the argument descriptions directly in the integration YAML and regenerate the README using the SDK, rather than editing the markdown manually. You'll also need to populate the empty release notes using the SDK and add the missing created key and keywords to the pack metadata. Thanks again!
Additionally, please address the following file-level notes:
Packs/MicrosoftGraphApplications/Integrations/MicrosoftGraphApplications/README.md: The PR intent mentions mappingreply_urlsto a list, but the description forreply_urlsin the README does not explicitly state that it accepts a comma-separated list of URLs. Consider updating the description in the integration YAML to clarify this.
Additionally, it appears the argument table was manually edited to remove the phantom arguments. Please ensure you update the descriptions in the integration YAML file and use Run demisto-sdk generate-docs to regenerate the README. This ensures formatting and context outputs remain perfectly aligned with the code.
Packs/MicrosoftGraphApplications/pack_metadata.json: - The mandatory keycreatedis missing from the pack metadata. Please add it.- The
keywordslist is empty. Please add 'Microsoft' to thekeywordslist. Packs/MicrosoftGraphApplications/ReleaseNotes/1_2_58.md: The release notes file is currently empty. Please auto-generate the release notes using thedemisto-sdk update-release-notescommand and ensure it follows the required Markdown hierarchy and uses approved prefixes.
For this integration change, the expected hierarchy is:
#### Integrations
##### Entra ID Applications
- Fixed an issue... (or another approved prefix)For more details, please refer to the General release notes documentation.
@noydavidi please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.
2fd5f46 to
e13ad37
Compare
This comment has been minimized.
This comment has been minimized.
|
Validate summary Verdict: PR can be force merged from validate perspective? ✅ |
…demisto/content into fix-msgraph-apps-reply-urls-phantom-arg
🔍 AI Triage Report AvailableAn automated triage report has been generated for this pipeline. Status: 📋 Triage Report
|
Fix reply_urls phantom arg in msgraph-apps-service-principal-update and aligned docs
Status
Related Issues
fixes: link to the issue
Must have