Skip to content

Fix reply_urls phantom arg in msgraph-apps-service-principal-update#44147

Merged
noydavidi merged 11 commits intomasterfrom
fix-msgraph-apps-reply-urls-phantom-arg
May 4, 2026
Merged

Fix reply_urls phantom arg in msgraph-apps-service-principal-update#44147
noydavidi merged 11 commits intomasterfrom
fix-msgraph-apps-reply-urls-phantom-arg

Conversation

@noydavidi
Copy link
Copy Markdown
Contributor

Fix reply_urls phantom arg in msgraph-apps-service-principal-update and aligned docs

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Must have

  • Tests
  • Documentation

@content-bot
Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2026

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/MicrosoftGraphApplications/Integrations/MicrosoftGraphApplications
   MicrosoftGraphApplications.py1161884%34–37, 115–116, 133, 148–150, 166–167, 182, 189–190, 224–225, 423
TOTAL1161884% 

Tests Skipped Failures Errors Time
26 0 💤 0 ❌ 0 🔥 2.770s ⏱️

noydavidi added 2 commits May 3, 2026 11:10
…demisto/content into fix-msgraph-apps-reply-urls-phantom-arg

# Conflicts:
#	Packs/MicrosoftGraphApplications/Integrations/MicrosoftGraphApplications/README.md
@noydavidi noydavidi added the ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines label May 3, 2026
@noydavidi noydavidi added the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label May 3, 2026
@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label May 3, 2026
@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@marketplace-ai-reviewer
Copy link
Copy Markdown
Contributor

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

Copy link
Copy Markdown
Contributor

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for your contribution to the Microsoft Graph Applications pack. I've reviewed the changes and have a few quick requests to help get this ready. Please make sure to update the argument descriptions directly in the integration YAML and regenerate the README using the SDK, rather than editing the markdown manually. You'll also need to populate the empty release notes using the SDK and add the missing created key and keywords to the pack metadata. Thanks again!

Additionally, please address the following file-level notes:

  • Packs/MicrosoftGraphApplications/Integrations/MicrosoftGraphApplications/README.md: The PR intent mentions mapping reply_urls to a list, but the description for reply_urls in the README does not explicitly state that it accepts a comma-separated list of URLs. Consider updating the description in the integration YAML to clarify this.

Additionally, it appears the argument table was manually edited to remove the phantom arguments. Please ensure you update the descriptions in the integration YAML file and use Run demisto-sdk generate-docs to regenerate the README. This ensures formatting and context outputs remain perfectly aligned with the code.

  • Packs/MicrosoftGraphApplications/pack_metadata.json: - The mandatory key created is missing from the pack metadata. Please add it.
  • The keywords list is empty. Please add 'Microsoft' to the keywords list.
  • Packs/MicrosoftGraphApplications/ReleaseNotes/1_2_58.md: The release notes file is currently empty. Please auto-generate the release notes using the demisto-sdk update-release-notes command and ensure it follows the required Markdown hierarchy and uses approved prefixes.

For this integration change, the expected hierarchy is:

#### Integrations
##### Entra ID Applications
- Fixed an issue... (or another approved prefix)

For more details, please refer to the General release notes documentation.

@noydavidi please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

@noydavidi noydavidi force-pushed the fix-msgraph-apps-reply-urls-phantom-arg branch from 2fd5f46 to e13ad37 Compare May 3, 2026 10:35
Comment thread Packs/MicrosoftGraphApplications/ReleaseNotes/1_2_58.md Outdated
@noydavidi noydavidi requested a review from Shellyber May 3, 2026 12:42
Copy link
Copy Markdown
Contributor

@Shellyber Shellyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
See my comment.

@content-bot

This comment has been minimized.

@content-bot
Copy link
Copy Markdown
Contributor

Validate summary
The following errors were thrown as a part of this pr: DO106.
The following errors cannot be ignored: DO106.
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.
The following errors don't run as part of the nightly flow and therefore can be force merged: DO106.

Verdict: PR can be force merged from validate perspective? ✅

…demisto/content into fix-msgraph-apps-reply-urls-phantom-arg
@content-bot
Copy link
Copy Markdown
Contributor

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: failed
Report ID: f207b650db81bb96

📋 Triage Report
💡 Resolutions are available in the full report.

⚠️ AI-generated triage. Validate before acting.

@noydavidi noydavidi merged commit 85883bd into master May 4, 2026
22 checks passed
@noydavidi noydavidi deleted the fix-msgraph-apps-reply-urls-phantom-arg branch May 4, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants