Skip to content

Tenable sc ingest - updated _time mapping and default fetch interval#44479

Merged
DeanArbel merged 16 commits into
masterfrom
contrib/andrew-paloalto_tenable-sc-ingest-2
Jun 2, 2026
Merged

Tenable sc ingest - updated _time mapping and default fetch interval#44479
DeanArbel merged 16 commits into
masterfrom
contrib/andrew-paloalto_tenable-sc-ingest-2

Conversation

@content-bot
Copy link
Copy Markdown
Contributor

@content-bot content-bot commented Jun 1, 2026

Original External PR

external pull request

Contributor

@andrew-paloalto

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Must have

  • Tests
  • Documentation

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-16931

@andrew-paloalto
Tenable sc ingest - updated _time mapping and default fetch interval (#…
e6f0fb1 
…44458)

* adding WIP code for Tenable.sc asset & vuln ingest

* add time formatting and unit test failure

* pre-commit hook updates

* Remove Asset Modeling Rules

* explicitly exclude WAS findings

* fix failing test

* ruff format

* remove timestamp formatting

* swap vuln _time mapping and use 12h default fetch interval w/ 1h min

* fix failing test
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved Contribution Form Filled Whether contribution form filled or not. Community Xsoar Support Level Indicates that the contribution is for XSOAR supported pack Internal PR ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines labels Jun 1, 2026
@content-bot content-bot requested a review from YaelShamai June 1, 2026 07:15
@content-bot
Copy link
Copy Markdown
Contributor Author

content-bot commented Jun 1, 2026

🤖 AI-Powered Code Review Available

Hi @YaelShamai, you can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@content-bot
Copy link
Copy Markdown
Contributor Author

content-bot commented Jun 1, 2026

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Tenable_sc/Integrations/Tenable_sc
   Tenable_sc.py107930471%68–74, 88–97, 100, 114–115, 130–132, 134–135, 137–138, 140, 142–145, 147–151, 156, 158, 164–165, 167–168, 170, 173–178, 180–181, 191, 193–194, 196–197, 200–201, 203, 209–210, 291–292, 296, 300–303, 364, 516, 519, 582, 584, 586, 596–599, 610, 612, 647, 655, 698, 700, 705, 763, 765, 776, 778, 825, 836, 838, 998, 1051, 1091, 1110, 1115, 1154, 1159, 1198, 1203, 1232, 1237, 1278, 1283, 1324, 1376, 1412, 1431, 1443, 1483, 1557, 1616, 1618, 1620, 1628, 1652–1659, 1661–1668, 1670, 1694, 1746, 1767, 1819, 1821–1825, 1845, 1847–1848, 1850, 1858, 1860, 1862–1863, 1865, 1867–1868, 1870, 1872–1873, 1882, 1884, 1886, 1888, 1900–1901, 1903, 1905–1906, 1908, 1910–1911, 1913, 1915–1916, 1918–1919, 1921, 1923–1925, 1927–1930, 1932, 1942, 1944, 1946, 1953, 1960–1961, 1964–1968, 1970–1974, 1976, 1980, 1990–1991, 1993, 2004, 2024, 2046, 2123, 2134, 2137, 2178, 2211, 2216, 2270, 2275, 2314, 2355, 2384, 2414–2418, 2420–2421, 2423, 2425–2426, 2431–2432, 2434–2435, 2443–2444, 2446–2447, 2463, 2512, 2515, 2580–2583, 2595–2599, 2611–2613, 2625–2626, 2639, 2677, 2708–2710, 2725, 2741, 2759–2768, 2770, 2772, 2790, 2808, 2854, 2872, 2898, 3034–3035, 3074, 3192–3193, 3199–3207, 3209–3210, 3253, 3255–3264
TOTAL107930471% 

Tests Skipped Failures Errors Time
95 0 💤 0 ❌ 0 🔥 3.456s ⏱️

@YaelShamai YaelShamai added the ForceMerge Forcing the merge of the PR despite the build status label Jun 1, 2026
@YaelShamai
Copy link
Copy Markdown
Contributor

YaelShamai commented Jun 1, 2026

Validation fails on RN even though it is written properly. Need to force merged.

kobymeir
kobymeir previously requested changes Jun 1, 2026
View reviewed changes
Comment thread Packs/Tenable_sc/ReleaseNotes/1_2_0.md Outdated

##### Tenable.sc

- Updated the Docker image to *demisto/python3:3.12.13.9059085*.
Copy link
Copy Markdown
Contributor

@kobymeir kobymeir Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Updated the Docker image to *demisto/python3:3.12.13.9059085*.
- Updated the Docker image to: *demisto/python3:3.12.13.9059085*.

Copy link
Copy Markdown
Contributor

@YaelShamai YaelShamai Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@content-bot

This comment has been minimized.

Sign in to view
@content-bot

This comment has been minimized.

Sign in to view
@DeanArbel DeanArbel requested a review from kobymeir June 2, 2026 14:31
@content-bot
Copy link
Copy Markdown
Contributor Author

content-bot commented Jun 2, 2026

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: failed
Report ID: fbd400174c8db1e8

📋 Triage Report
💡 Resolutions are available in the full report.

⚠️ AI-generated triage. Validate before acting.

@YaelShamai
Copy link
Copy Markdown
Contributor

YaelShamai commented Jun 2, 2026

TestPlaybooks are failing do to expired creds. Need to force merge

@content-bot
Copy link
Copy Markdown
Contributor Author

content-bot commented Jun 2, 2026

Validate summary
The following errors were thrown as a part of this pr: IN156.
The following errors cannot be ignored: IN156.
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ❌

@DeanArbel DeanArbel merged commit 2384828 into master Jun 2, 2026
20 of 21 checks passed
@DeanArbel DeanArbel deleted the contrib/andrew-paloalto_tenable-sc-ingest-2 branch June 2, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YaelShamai YaelShamai YaelShamai approved these changes

@kobymeir kobymeir Awaiting requested review from kobymeir

Assignees

@YaelShamai YaelShamai

Labels

Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved ForceMerge Forcing the merge of the PR despite the build status Internal PR ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines skip-ai-review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@content-bot @YaelShamai @kobymeir @DeanArbel @andrew-paloalto @DanielTal87