Skip to content

Conversation

@alexcurylo
Copy link
Contributor

Allows setting of "Project", "Shared" and "-" separator via Preferences.

Allows setting of "Project", "Shared" and "-" separator via Preferences.
@dempseyatgithub
Copy link
Owner

Thank you for taking the time to do work on this. Exposing these as settings is definitely something I was planning on getting to at some point!

A goal was that the BuildSettingExtractor class was configurable without directly accessing user defaults, so a change I’d recommend would be to add the default hyphen in the -init method itself, so that a newly created BuildSettingExtractor instance can be used with default values.

Then I’d set the values pulled from user defaults after the new build setting extractor is created. Like is done with includeBuildSettingInfoComments.

I’m also on the fence about including the .gitignore in the project. I have a user-level .gitignore and different folks have the own tweaked files.

Default shared/project/separator providers exposed for clients to manage NSUserDefaults should they wish.
@alexcurylo
Copy link
Contributor Author

Excellent point. Defaults now provided by BuildSettingExtractor.

Not relevant to output configuration PR.
dempseyatgithub added a commit that referenced this pull request May 16, 2015
Add naming preferences for generated files. Thank you alexcurylo!
@dempseyatgithub dempseyatgithub merged commit 06ac5d1 into dempseyatgithub:master May 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants