Skip to content

Conversation

@joprice
Copy link
Contributor

@joprice joprice commented Jan 7, 2025

Proposed Changes

Adds explicit type parameter to Task.ignore to improve type-directed refactoring, as discussed in #299

Types of changes

What types of changes does your code introduce to FsToolkit.ErrorHandling?
Put an x in the boxes that apply and remove ones that don't apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Copy link
Collaborator

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Did a quick check of other places, think it's worth adding it to Option as well?

let inline ignore (opt: 'T option) : unit option =

@joprice
Copy link
Contributor Author

joprice commented Jan 7, 2025

The more the merrier.

@TheAngryByrd TheAngryByrd merged commit 276bc28 into demystifyfp:master Jan 7, 2025
@joprice joprice deleted the ignoreExplicitType branch January 8, 2025 00:20
@TheAngryByrd TheAngryByrd mentioned this pull request Mar 5, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants