Merged
Conversation
These are basically less-useful versions of L-BFGS-B
…rithms Rather than Bounds being explicitly given when the minimizer is created, they are now part of the function, except in the cases of algorithms which support bounds, in which case they are part of the algorithm. This distinguishes the act of transforming functions to make them bounded and using a algorithm that supports bounding standard functions. A wrapper struct, `BoundedFunction`, is provided to handle the former case. This also moves tolerances out of terminators and into the main algorithm structs, which is mostly aesthetic but also gets around a few annoyances in coding.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
==========================================
- Coverage 54.73% 50.53% -4.21%
==========================================
Files 12 8 -4
Lines 2585 2145 -440
==========================================
- Hits 1415 1084 -331
+ Misses 1170 1061 -109 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #63 will improve performances by 10.61%Comparing Summary
Benchmarks breakdown
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that I have a better sense of what I'm doing here, it's time to make this crate a bit more organized. I've reverted the tuning method that was added in the previous patch, it's fairly useless as far as I can tell. The biggest update here is that bounds are separated from the minimizer/sampler structures. Instead, algorithms which support bounds should store them in the algorithm initialization, and algorithms which don't can always take a
BoundedFunctionwrapper which does the bounds transformation implicitly.There is still some work that needs to be done to fully decouple these, for example the
NelderMeadalgorithm still uses bounds in places outside function evaluations. There should probably be some closer coupling betweenBoundandPoint, but I'll figure that out later.