Reorganization and Generation#110
Merged
Merged
Conversation
…r submodules and updated cargo fmt settings
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 78.00% 78.29% +0.28%
==========================================
Files 66 104 +38
Lines 27020 26149 -871
Branches 26360 25469 -891
==========================================
- Hits 21077 20473 -604
+ Misses 5454 5131 -323
- Partials 489 545 +56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is all about reorganizing the underlying crate structure to make it a bit easier to find things. Files were getting very large and hard to read through, and I figured it made sense to break up some of these bigger files into submodules. Eventually I might break things up in to small crates to improve compile times even more, but for now this is probably fine.
The other major addition is the
laddu-generationcrate. My goal here was to allow an experiment-agnostic Monte Carlo generator to generateladduDatasets with some extra metadata that can be used by experiment-specific translators to convert data to whatever pipeline an experiment uses.A more detailed summary is as follows:
Dataset and Event APIs
Eventviews rather than cloning or exposing awkward internal storage details.events_localandevents_globalstyle accessors so MPI/local semantics are visible at the call site.push_event_localpush_event_globaladd_p4_column_localadd_p4_column_globaladd_aux_column_localadd_aux_column_globalReaction and Generation APIs
laddu-generationas a first-class workspace crate and re-exported generation APIs through the top-level Rust and Python packages.Particle/Reactionconstruction semantics.Parameters and Likelihoods
ParameterMaprather than separate free/fixed parameter APIs.ParameterMapwith indexing, containment, free/fixed filtered views, and improved string/repr behavior.LikelihoodEvaluatorsplit by merging evaluator-like behavior into likelihood expressions.Amplitudes, Tags, and Expression Compilation
Concrete Amplitudes and Physics Helpers
laddu-coreso they are available without depending onladdu-amplitudes.Python API Organization
laddu.amplitudefor core expression/evaluator/parameter APIs.laddu.amplitudes.*for concrete amplitude constructors.laddu.data,laddu.generation,laddu.reaction,laddu.variables,laddu.vectors,laddu.math, andladdu.quantumfor their Rust counterparts.laddu.likelihood,laddu.optimize, andladdu.experimental, which map toladdu-extensionsin Rust..pyifiles, top-level exports, and smoke tests for module import parity.Documentation and Tests
Breaking Changes
laddu_core::amplitudesis nowladdu_core::amplitude.ParameterMap; separate free/fixed shortcut APIs were removed or reduced.