How to merge multiple packages attrsets from different aspects instead of letting the last include win ?

[tristandruyen]

How can I merge packages defined in multiple aspects ?

I've tried this:

den.aspects.package_1.packages = { pkgs, ... }: {
    package_1 = pkgs.writeShellApplication {
        name = "package_1";
        text = 'echo 1';
    };
};
den.aspects.package_2.packages = { pkgs, ... }: {
    package_2 = pkgs.writeShellApplication {
        name = "package_2";
        text = 'echo 2';
    };
};

den.schema.flake-system = {
    includes = [
      den.aspects.package_1
      den.aspects.package_2
    ];
};

Which leads to just package_2 showing up in the flake output. (i can change that by reordering the aspects in the includes )

And also this:
https://den.denful.dev/reference/output/#flake-outputs-like-packages-checks-etc

The inputs.den.flakeOutputs.packages include fails with:

The option `flake.packages' in `/nix/store/ch5n4xdddid5859dy6c4i6lghqyx8016-source/modules/packages.nix' is already declared in `/nix/store/phj5s9cr2wvcd0j9xghacrgxfnv6n47w-source/modules/packages.nix'.

Which makes some sense as it says it's only required when not using flake-parts which I am.

Following the other steps doesn't work at all (no packages in output). I guess because the den.schema.flake-packages doesn't exist anymore and docs are outdated ?

I can reproduce the same behavior as with my full config, but including inputs.den.flakeOutputs.packages, using the minimal template without flake-parts.

I'm probably holding it wrong am I not ?

[theutz]

Have you tried including them on den.schema.flake-packages instead of den.schema.flake-system?

# ANY Host or User aspect can produce outputs:
# The flake-system-to-flake-os policy handles host fan-out.
# To include aspects in flake outputs:
den.schema.flake-packages.includes = [ den.aspects.foo ];

[btrzcinski]

I also tried just the policy include, which has the same result.

I added a test case next to the single aspect one that repros.

[sini]

I'll give it a look at hot fix later this morning

[tristandruyen]

I've tried den.schema.flake-packages.includes, but then I get no packages in the flake output at all ...

[sini]

@tristandruyen

Did you test with a version of den after this PR landed?
#574

[tristandruyen]

Works perfectly with #574 👍 🚀

[theutz]

@sini Haven't had a chance to repro, but multiple users reporting. May be a regression?