v0.18.0 Strict Mode lacks definitions for core class types

[DylanRJohnston]

Hey all, finally have some time to update my Den config to v0.18.0 and I'm going through try to understand the new effect system. As fas I can tell, when inputs.den.flakeModules.strict is enabled, none of the core class types have registered themselves with the den.schema.aspects schema module. e.g.

{ denTest, ... }:
{
  flake.tests.issue-xxx-user-strict-mode = {

    test-user-class-works-in-strict-mode = denTest (
      {
        inputs,
        igloo,
        ...
      }:
      {
        imports = [ inputs.den.flakeModules.strict ];

        den.hosts.x86_64-linux.igloo.users.tux = { };
        den.aspects.tux.user.isNormalUser = false;

        expr = igloo.users.users.tux.isNormalUser;
        expected = false;
      }
    );
  };
}

 error: STRICT MODE

   Attempted to set the option "nixos" in "den.aspects.igloo" but no explicit definition exists. If this wasn't a mistake, disable STRICT mode or configure an option. e.g.

   den.schema.aspects.options.nixos = lib.mkOption { ... };

Is this the intended behaviour? That users type all of the core classes themselves? Or should they each respectively register their types with den.schema.aspects?

[DylanRJohnston]

There was some discussion of strict by default here but it seems like that wasn't enabled otherwise everyone would be having this issue?

I was also having trouble figuring out what the type should be, I think it needs to be some variation of this?

den/nix/lib/aspects/types.nix

Line 599 in 3932adf

aspectKeyType =

[DylanRJohnston]

Ugh, now we're back to the problem of defined options setting key = null, so existence checks on keys break 🙃 , just like with expectedErr in denTest

{ denTest, ... }:
{
  flake.tests.issue-xxx-user-strict-mode = {

    test-user-class-works-in-strict-mode = denTest (
      {
        inputs,
        igloo,
        lib,
        den,
        ...
      }:
      {
        imports = [ inputs.den.flakeModules.strict ];

        den.schema.aspect.options.nixos = lib.mkOption {
          type = lib.types.anything;
        };

        den.schema.aspect.options.homeManager = lib.mkOption {
          type = lib.types.anything;
        };

        den.schema.aspect.options.user = lib.mkOption {
          type = lib.types.anything;
        };

        den.hosts.x86_64-linux.igloo.users.tux = { };
        den.aspects.tux.user.isNormalUser = false;

        expr = igloo.users.users.tux.isNormalUser;
        expected = false;
      }
    );
  };
}

error: The option `den.aspects.igloo.homeManager' was accessed but has no value defined. Try setting the option.

[DylanRJohnston]

Maybe we just abandon strict mode?

[sini]

@DylanRJohnston I'm just about done with https://github.com/sini/gen -- all core libs should be ready -- and with that comes a den rewrite that should give you your strictness/validation guarantees. :)

[DylanRJohnston]

Alright, so I should probably hold off for the next big rewrite then?