BUG: unfree battery broken for Home Manager packages

[OscarMarshall]

The den._.unfree battery is broken under Home Manager. Here's my repro.

It fails with the message:

error: The option `home-manager.users.tux.unfree.packages' in `/nix/store/b79a4h16k59h5hxq696xfsvspk4av19g-source/modules/aspects/provides/unfree/unfree-predicate-builder.nix, via option den.default.includes."[definition 1-entry 1]".<function body>.includes."[definition 1-entry 1]".homeManager' is already declared in `/nix/store/b79a4h16k59h5hxq696xfsvspk4av19g-source/modules/aspects/provides/unfree/unfree-predicate-builder.nix, via option den.default.includes."[definition 1-entry 1]".<function body>.includes."[definition 1-entry 1]".homeManager'.

I noticed this bug is only present in the newest commit: fix(hm): parametric aspects at user.includes are accounted now.

[Adda0]

I seem to have the same issue, but with den._.inputs' inside a private namespace. And it too should be caused by the latest changes right before version 0.8.0. It worked for me on 7431d48.

       error: The option `home-manager.users.adda._module.args.inputs'' is defined multiple times while it's expected to be unique.

       Definition values:
       - In `/nix/store/nipfam1zr33djdf5wzqilwwdvyklrhcg-source/modules/aspects/provides/inputs.nix, via option den.provides.inputs'.<function body>.includes."[definition 1-entry 1]".homeManager'
       - In `/nix/store/nipfam1zr33djdf5wzqilwwdvyklrhcg-source/modules/aspects/provides/inputs.nix, via option den.provides.inputs'.<function body>.includes."[definition 1-entry 1]".homeManager'
       Use `lib.mkForce value` or `lib.mkDefault value` to change the priority on any of these definitions.

Cannot prepare a reproducible example right now, but may try to do so later if needed.

den.default.includes = [ den._.inputs' ];
...
myNamespace.foo.homeManager = {inputs', ...}: {home.packages = [inputs'.bar.packages.default]; }

Something along those lines.

[vic]

omg! will take a look later tonight. I guess we need more tests for unfree/inputs' just to make sure we have no regressions.

[Adda0]

I confirm this is fixed for me. Many thanks for the fix ❤️