Merged
Conversation
Per the v0.9.0 upgrade instructions, taking `OS` as a parameter is no longer a thing. I noticed this instance when checking out the examples template to see how `den.ctx` affected it.
There was a problem hiding this comment.
Pull request overview
This PR updates the example template to align with v0.9.0 by removing the deprecated OS parameter from a context-aware function in the defaults.nix file. The OS parameter is no longer part of the standard context parameters used in Den (which now uses host, user, and home).
Changes:
- Removed
OSparameter from function signature in example defaults.nix - Removed unnecessary
den.lib.take.unused OSwrapper
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
thanks I forgot that one when rewriting all tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the v0.9.0 upgrade instructions, taking
OSas a parameter is no longer a thing. I noticed this instance when checking out the examples template to see howden.ctxaffected it.