Skip to content

feat(battery): New den._.hostname and .. #236

Merged
vic merged 12 commits intodenful:mainfrom
musjj:new-batteries
Mar 7, 2026
Merged

feat(battery): New den._.hostname and .. #236
vic merged 12 commits intodenful:mainfrom
musjj:new-batteries

Conversation

@musjj
Copy link
Copy Markdown
Contributor

@musjj musjj commented Mar 6, 2026

Convert two well-known patterns from the examples into built-in batteries:

  • Bidirectional provider
  • Automatically setting networking.hostName

I feel that these two use-cases are common enough that they are worth being lifted up into the built-in set of batteries.

What do you think?

Also, I would like to hear if you have any better ideas for the names:

  • den._.set-hostname: Maybe too specific? In the future, will there be any other use-cases for auto-configuring hosts that could be included in this battery?
  • den._.bidirectional-provider: Feels descriptive, but maybe too long?

Comment thread modules/aspects/provides/bidirectional-provider.nix Outdated
Comment thread modules/aspects/provides/set-hostname.nix Outdated
Comment thread docs/src/content/docs/guides/batteries.mdx Outdated
Comment thread docs/src/content/docs/guides/batteries.mdx Outdated
Comment thread docs/src/content/docs/tutorials/example.md
@vic
Copy link
Copy Markdown
Member

vic commented Mar 6, 2026

Hey, @musjj. I like the idea of having them as batteries. I've added some comments for you.

@vic vic changed the title New batteries feat(batteries): New batteries Mar 6, 2026
@vic vic changed the title feat(batteries): New batteries feat(battery): New den._.hostname and .. Mar 6, 2026
@vic
Copy link
Copy Markdown
Member

vic commented Mar 6, 2026

Also, if we are having new batteries, be sure to also have some tests for them in templates/ci.

Comment thread templates/ci/modules/features/deadbugs/cybolic-routes.nix
Comment thread modules/aspects/provides/bidirectional-provider.nix Outdated
Comment thread modules/aspects/provides/bidirectional-provider.nix Outdated
Comment thread modules/aspects/provides/bidirectional-provider.nix Outdated
@vic
Copy link
Copy Markdown
Member

vic commented Mar 7, 2026

Looks good, just rename to mutual-provider, update the link and we'll merge.

@musjj
Copy link
Copy Markdown
Contributor Author

musjj commented Mar 7, 2026

Done!

@vic vic added the allow-ci allow all CI integration tests label Mar 7, 2026
@vic vic merged commit a63a4c3 into denful:main Mar 7, 2026
22 checks passed
@vic
Copy link
Copy Markdown
Member

vic commented Mar 7, 2026

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

allow-ci allow all CI integration tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants