Skip to content

feat(ci): Add Docs build at CI#270

Merged
vic merged 1 commit intomainfrom
doc
Mar 12, 2026
Merged

feat(ci): Add Docs build at CI#270
vic merged 1 commit intomainfrom
doc

Conversation

@vic
Copy link
Copy Markdown
Member

@vic vic commented Mar 12, 2026

This is to prevent accepting PR that break the site build.

Fixes #269

This is to prevent accepting PR that break the site build.

Fixes #269
@vic vic merged commit edaa0b0 into main Mar 12, 2026
2 checks passed
@vic vic deleted the doc branch March 12, 2026 19:33
@ulfbayte
Copy link
Copy Markdown
Contributor

ulfbayte commented Mar 12, 2026

@vic Sorry for this...
Can I use some tool to avoid this situation next time ? (edit ok it's pnpm stuff, I will try to build before submitting instead of relying on preview)

@vic
Copy link
Copy Markdown
Member Author

vic commented Mar 12, 2026

Can I use some tool to avoid this situation next time ? (edit ok it's pnpm stuff, I will try to build before submitting instead of relying on preview)

no worries, I understand, I actually want people to submit PR directly from their browser, that's why we have that "Edit this page" button. If you however have a clone of the repo you can run pnpm run build or pnpm run dev to see your changes locally. I added a github action just to prevent errors reaching main branch, I still want people to send PRs and I'm willing to fix them if they dont have the project, #270 is a way to alert me (or contributors) before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: Add CI pnpm run build Make sure docs Build

2 participants