fix: strip _ aliases from external denful to prevent include duplication#402
Merged
sini merged 1 commit intodenful:mainfrom Apr 8, 2026
Merged
Conversation
When an external namespace's evaluated config is re-imported via den.namespace, both _ and provides contain identical content due to the _ → provides alias in aspectSubmodule. The module system merges both paths, causing listOf options like includes to duplicate entries. Strip _ from external denful configs before assignment to den.ful. Fixes denful#400
vic
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an external namespace's evaluated config is re-imported via den.namespace, both _ and provides contain identical content due to the _ → provides alias in aspectSubmodule. The module system merges both paths, causing listOf options like includes to duplicate entries.
Strip _ from external denful configs before assignment to den.ful.
Fixes #400