feat: forward and output resolution respects meta.adapter#405
Merged
vic merged 1 commit intodenful:mainfrom Apr 8, 2026
Merged
feat: forward and output resolution respects meta.adapter#405vic merged 1 commit intodenful:mainfrom
vic merged 1 commit intodenful:mainfrom
Conversation
sini
force-pushed
the
sf5/forward-consumption
branch
from
bd477ad to
c3d0355
Compare
vic
requested changes
Apr 8, 2026
sini
force-pushed
the
sf5/forward-consumption
branch
from
c3d0355 to
fc70ebe
Compare
sini
force-pushed
the
sf5/forward-consumption
branch
2 times, most recently
from
e835830 to
2bd9c5b
Compare
sini
commented
Apr 8, 2026
sini
force-pushed
the
sf5/forward-consumption
branch
2 times, most recently
from
5325770 to
2f101fc
Compare
vic
requested changes
Apr 8, 2026
sini
force-pushed
the
sf5/forward-consumption
branch
6 times, most recently
from
6b1f479 to
1f3819f
Compare
Entities expose .resolved (their context pipeline result) via the entityCtx helper. forward.nix defaults to item.resolved when fromAspect is absent, enabling cross-context forwarding. mainModule simplified to use config.resolved directly, removing the mainModule helper. Adapter propagation tests consolidated into one file with end-to-end coverage including transitive context-level filtering.
sini
force-pushed
the
sf5/forward-consumption
branch
from
1f3819f to
68bb610
Compare
vic
approved these changes
Apr 8, 2026
Member
|
Amazing, @sini! keep those stacked PRs coming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.resolved— the result of their context pipeline — derived from the schema type systemforward.nixdefaults toitem.resolvedwhenfromAspectis absent, enabling cross-context forwarding without manual wiringmainModulehelper eliminated — entity types resolve directly viaconfig.resolvedWhat changed
options.nix —
schemaEntryTypewrapsdeferredModuleto auto-injectconfig.resolvedfor any schema entry whereden.ctx.${kind}exists. Context args are derived from the entity's_module.args, filtered to known context kinds. No per-entity boilerplate — host, user, and home all get.resolvedautomatically.types.nix —
mainModulehelper removed. Both host and homemainModuleoptions simplified toden.lib.aspects.resolve config.class config.resolved.forward.nix —
aspfalls back toitem.resolved or itemwhenfromAspectis absent.How context adapters flow through forwards
den.ctx.host.meta.adapteris carried throughctxApply(viawithIdentityfrom #398) onto.resolved. Whenresolveprocesses it,adapters.filterIncludes(from #397) picks up the adapter and applies it transitively to the entire subtree — including nested aspects reached through forwards.