feat: tombstones, identity paths, and substitution in filterIncludes#409
Merged
sini merged 1 commit intodenful:mainfrom Apr 8, 2026
Merged
Conversation
filterIncludes now produces tombstones (~name, meta.excluded) for excluded includes instead of silently dropping them. Tombstones are empty aspects harmless to module but visible to trace/debug adapters. Substituted includes produce a tombstone for the original plus the replacement, enabling both to appear in traces. New adapters: - aspectPath: derive identity from name + provider (replaces == on aspects) - excludeAspect: exclude by aspect reference via path comparison - substituteAspect: substitute by aspect reference via mapAspect + path - tombstone: create a tombstone from a resolved aspect (exported utility)
sini
force-pushed
the
feat/adapter-tombstones-and-identity
branch
from
adddce0 to
500f15c
Compare
vic
approved these changes
Apr 8, 2026
Member
vic
left a comment
vic
left a comment
There was a problem hiding this comment.
lgtm, merge when you feel like it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
filterIncludes now produces tombstones (~name, meta.excluded) for excluded includes instead of silently dropping them. Tombstones are empty aspects harmless to module but visible to trace/debug adapters.
Substituted includes produce a tombstone for the original plus the replacement, enabling both to appear in traces.
New adapters: