fix: rename excludedBy to excludedFrom on tombstones#421
Merged
vic merged 1 commit intodenful:mainfrom Apr 9, 2026
Merged
Conversation
The value is the parent aspect whose meta.adapter caused the exclusion, not the agent doing the excluding. excludedFrom better describes "this aspect was excluded from server's subtree."
vic
reviewed
Apr 9, 2026
| # meta.provider — who defines this aspect (structural origin, from provides chain) | ||
| # meta.excludedBy — who excluded it (the aspect whose meta.adapter caused exclusion) | ||
| # meta.excludedFrom — the parent aspect whose meta.adapter caused the exclusion | ||
| # meta.replacedBy — name of the replacement (for substitutions only) |
Member
There was a problem hiding this comment.
so is replacedWith also a better name ? or is replacedBy a reference of who replaced the aspect ?
Collaborator
Author
There was a problem hiding this comment.
replacedBy is the aspect that was substituted
Member
There was a problem hiding this comment.
oh right, the value of replacedBy was the original aspect
Member
There was a problem hiding this comment.
naming is hard, you are much better than me at this.
Collaborator
Author
There was a problem hiding this comment.
ex;
desktop.includes[] resolves with an adapter sub(regreet,gdm)
regreet(excluded) -> gdm(inserted)
so the tombstone for regreet has excludedFrom = desktop replacedBy = gdm
vic
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value is the parent aspect whose meta.adapter caused the exclusion, not the agent doing the excluding. excludedFrom better describes "this aspect was excluded from server's subtree."