Skip to content

re-enable allfollow.#13

Merged
vic merged 1 commit into
mainfrom
allfollow
Jul 16, 2025
Merged

re-enable allfollow.#13
vic merged 1 commit into
mainfrom
allfollow

Conversation

@vic
Copy link
Copy Markdown
Member

@vic vic commented Jul 15, 2025

Now that allfollow is deterministic we no longer have to use jq to sort its output.

We now use delta instead of difftasitc to fail if flake.lock was not already pruned.

I'm not sure now that we need an allfollow check command, since it is better for users to see a nice diff as error message.

Related:
spikespaz/allfollow#7

Copilot AI review requested due to automatic review settings July 15, 2025 18:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR re-enables the allfollow tool by uncommenting previously disabled commands and updating the diff tool from difftastic to delta. The changes leverage the fact that allfollow is now deterministic, eliminating the need for jq to sort its output.

  • Re-enables allfollow apply and allfollow check commands that were previously commented out
  • Replaces difftastic with delta for diff operations and removes jq dependency
  • Simplifies the allfollow workflow by using --in-place flag for pruning operations

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
modules/write-flake.nix Uncomments allfollow apply and check commands
modules/allfollow.nix Updates runtime dependencies and simplifies allfollow script logic

Comment thread modules/allfollow.nix Outdated
@vic vic force-pushed the allfollow branch 7 times, most recently from 1c023b3 to 71b7a51 Compare July 16, 2025 03:31
@vic vic merged commit 07bebae into main Jul 16, 2025
5 checks passed
@vic vic deleted the allfollow branch July 16, 2025 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants