Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR re-enables the allfollow tool by uncommenting previously disabled commands and updating the diff tool from difftastic to delta. The changes leverage the fact that allfollow is now deterministic, eliminating the need for jq to sort its output.
- Re-enables
allfollow applyandallfollow checkcommands that were previously commented out - Replaces
difftasticwithdeltafor diff operations and removesjqdependency - Simplifies the allfollow workflow by using
--in-placeflag for pruning operations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| modules/write-flake.nix | Uncomments allfollow apply and check commands |
| modules/allfollow.nix | Updates runtime dependencies and simplifies allfollow script logic |
1c023b3 to
71b7a51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that allfollow is deterministic we no longer have to use jq to sort its output.
We now use
deltainstead ofdifftasitcto fail if flake.lock was not already pruned.I'm not sure now that we need an
allfollow checkcommand, since it is better for users to see a nice diff as error message.Related:
spikespaz/allfollow#7