Skip to content

feat: Support flake-parts-builder templates#23

Merged
vic merged 1 commit into
mainfrom
parts
Jul 21, 2025
Merged

feat: Support flake-parts-builder templates#23
vic merged 1 commit into
mainfrom
parts

Conversation

@vic
Copy link
Copy Markdown
Member

@vic vic commented Jul 20, 2025

No description provided.

@vic vic force-pushed the parts branch 5 times, most recently from fb03709 to f1efb42 Compare July 20, 2025 23:31
@vic vic marked this pull request as ready for review July 21, 2025 00:11
Copilot AI review requested due to automatic review settings July 21, 2025 00:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for flake-parts-builder templates by introducing new flake modules and reorganizing existing ones. The implementation allows incremental addition of templated parts to projects, providing a more flexible alternative to traditional flake templates.

Key changes include:

  • Addition of new flake modules: import-tree and flake-parts-builder
  • Refactoring of module organization to separate concerns
  • Enhanced documentation with usage examples and integration guides

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
modules/import-tree.nix New module that adds import-tree dependency configuration
modules/flake-parts-builder.nix Core module implementing flake-parts-builder functionality with meta configuration transformation
modules/dendritic/dendritic.nix Updated to use import-tree module instead of direct dependency
modules/dendritic/default.nix Added imports for new flake modules
modules/default.nix Restructured module exports and definitions for better organization
README.md Comprehensive documentation updates with new sections and usage examples
Comments suppressed due to low confidence (5)

modules/flake-parts-builder.nix:22

  • [nitpick] The variable name 'meta' is ambiguous as it could refer to the final result or metadata in general. Consider renaming to 'metaConfigs' or 'processedMeta' to clarify its purpose.
  meta = lib.pipe fp [

modules/flake-parts-builder.nix:20

  • The variable name 'fp' is too abbreviated and unclear. Consider renaming to 'flakePartsPaths' or 'importedPaths' to improve readability.
  fp = inputs.import-tree.addPath "./flake-parts";

modules/flake-parts-builder.nix:23

  • The parameter name 'i' is not descriptive. Consider using a more meaningful name like 'paths' or 'items' to improve code readability.
    (i: i.filter (lib.hasInfix "/flake-parts/meta/"))

modules/flake-parts-builder.nix:24

  • The parameter name 'i' is not descriptive. Consider using a more meaningful name like 'paths' or 'items' to improve code readability.
    (i: i.map import)

modules/flake-parts-builder.nix:25

  • The parameter name 'i' is not descriptive. Consider using a more meaningful name like 'paths' or 'items' to improve code readability.
    (i: i.map metaToConfig)

@vic vic merged commit bd89d57 into main Jul 21, 2025
5 checks passed
@vic vic deleted the parts branch July 21, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants