remove mightyiam/files dependency.#3
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the legacy mightyiam/files dependency and its write-files tooling, replacing it with a new write-flake module and command. Key changes include:
- Dropping all
filesinputs and modules, and introducingwrite-flake.nixfor flake generation. - Updating templates, modules, and the regeneration scripts to use
nix run .#write-flake. - Simplifying CI workflows and documentation to reflect the new generator.
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/dendritic/flake.nix | Updated regeneration comment; removed files input |
| templates/default/modules/default.nix | Removed inputs.files.flakeModules.default; updated imports |
| templates/default/flake.nix | Updated regeneration comment; removed files input |
| modules/write-flake.nix | Added new module defining write-flake and its checks |
| modules/write-files.nix | Removed old write-files module |
| modules/options.nix | Updated header comment default to reference write-flake |
| modules/files.nix | Removed deprecated files module |
| modules/dendritic/basic.nix | Removed inputs.files import and default URL |
| modules/dendritic.nix | Swapped out files.nix import for basic.nix |
| modules/default.nix | Replaced write-files.nix import with write-flake.nix |
| dev/modules/regen.nix | Switched regeneration to write-flake; updated argument quoting |
| dev/flake.nix | Updated regeneration comment; removed files input |
| README.md | Replaced write-files instructions and removed files mentions |
| .github/workflows/flake-check.yaml | Simplified CI to use ./dev#fmt and ./dev#regen via write-flake |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.