Preserve follows bug#35
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug related to preserving follows declarations in flake inputs by refactoring the input processing logic. The changes extract utility functions into a shared library module and add comprehensive test coverage for the inputsExpr function.
- Extracted
inputsExprandisNonEmptyStringfunctions to a reusable_lib.nixmodule - Fixed handling of
followsattribute in input processing - Added unit tests for
inputsExprusing nix-unit framework
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| modules/write-flake.nix | Removed duplicate utility functions and imports them from new shared library |
| dev/modules/_lib.nix | New shared library containing extracted utility functions for input processing |
| dev/modules/unit-tests/inputsExpr.nix | New unit test file testing various input scenarios including follows handling |
| dev/modules/nix-unit.nix | Configuration for nix-unit testing framework |
| dev/flake.nix | Added nix-unit as a dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
added unit tests Fix #32. fmt make _lib a dir
vic
force-pushed
the
preserve-follows-bug
branch
from
5ca731f to
53e5292
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32