Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reduces the size of generated flake.nix files by collapsing single-attribute nested structures into dot notation (e.g., { flake-file = { url = "..."; }; } becomes flake-file.url = "...").
Key Changes:
- Introduced a new
nixAttrfunction that recursively collapses single-attribute nested structures - Modified
nixCodeto usenixAttrfor attribute transformation before code generation - Regenerated all template flake.nix files using the new logic
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| modules/write-flake.nix | Implements the core nixAttr function for collapsing nested single-attribute structures and integrates it into nixCode |
| templates/parts/flake.nix | Regenerated with collapsed input declarations (5 inputs collapsed from nested to dot notation) |
| templates/dendritic/flake.nix | Regenerated with collapsed input declarations (7 inputs collapsed, mixed with multi-attribute inputs) |
| templates/default/flake.nix | Regenerated with collapsed input declarations (4 inputs collapsed from nested to dot notation) |
| dev/flake.nix | Regenerated with collapsed input declarations (complex mix of collapsed and preserved multi-attribute structures) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -26,14 +26,33 @@ let | |||
| addHeader | |||
| ]; | |||
|
|
|||
There was a problem hiding this comment.
The new nixAttr function lacks a comment explaining its purpose and behavior. Consider adding documentation similar to the comment on line 47 for nixCode.
For example:
# Recursively collapse single-attribute nested structures
# e.g., { foo = { bar = "baz"; }; } becomes { name = "foo.bar"; value = "baz"; }
nixAttr =
name: value:
...
Suggested change
| # Recursively collapse single-attribute nested structures | |
| # e.g., { foo = { bar = "baz"; }; } becomes { name = "foo.bar"; value = "baz"; } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.