Skip to content

Allow empty url on root input and have a follows.#8

Merged
vic merged 1 commit into
mainfrom
root
Jul 15, 2025
Merged

Allow empty url on root input and have a follows.#8
vic merged 1 commit into
mainfrom
root

Conversation

@vic
Copy link
Copy Markdown
Member

@vic vic commented Jul 15, 2025

Fixes #4

Copilot AI review requested due to automatic review settings July 15, 2025 10:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the flake input configuration to allow empty URLs on the root input and adds a new follows option for flake inputs.

  • Sets url default to an empty string and introduces follows-option for follow paths.
  • Adjusts inputsExpr in write-flake.nix to prepare for conditional handling of url and follows (currently commented out).

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
modules/write-flake.nix Replaced direct url inheritance in inputsExpr with an empty block and commented out conditional snippets.
modules/options.nix Added follows-option, set default url to "", and wired follows into both top-level and submodule options.
Comments suppressed due to low confidence (1)

modules/options.nix:18

  • [nitpick] The new follows option is not described in the module documentation or README. Please add documentation explaining its purpose, default behavior, and example usage.
  follows-option = lib.mkOption {

Comment thread modules/write-flake.nix
@vic vic merged commit 4c83bd7 into main Jul 15, 2025
2 checks passed
@vic vic deleted the root branch July 15, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follows syntax is problematic for root follows

2 participants