Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the regen workflow into standalone shell‐application packages, updates an option type alias, and adjusts the CI workflow settings.
- Change the Nix option type alias from
lib.types.stringtolib.types.str - Introduce
oneach,each, andpukeshell applications and simplifyregen.nixto compose them - Update GitHub Actions to run on macOS and adjust
nix runinvocation flags
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| modules/options.nix | Switched option type from lib.types.string to lib.types.str |
| dev/modules/regen.nix | Added oneach, each, puke wrappers and replaced inline regen logic with composition |
| .github/workflows/flake-check.yaml | Changed runs-on to macos-latest and updated nix run commands |
Comments suppressed due to low confidence (3)
.github/workflows/flake-check.yaml:8
- [nitpick] Confirm that your Nix environment and dependencies work on macOS runners; if Linux is preferred for consistency, consider reverting to
ubuntu-latest.
runs-on: macos-latest
.github/workflows/flake-check.yaml:13
- The trailing
-- -Lflag will be passed to yourregenscript rather than as a Nix override; remove or replace it with the intended--override-input flake-file "$PWD"flags.
- run: nix run -L --override-input flake-file $PWD ./dev#regen -- -L
modules/options.nix:21
- Verify that
lib.types.stris a valid alias forstring; if not, revert tolib.types.stringor add an alias inlib/types.nixto avoid type errors.
type = lib.types.str;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.