Skip to content

chore(regen): split into scripts.#9

Merged
vic merged 1 commit into
mainfrom
regen
Jul 15, 2025
Merged

chore(regen): split into scripts.#9
vic merged 1 commit into
mainfrom
regen

Conversation

@vic
Copy link
Copy Markdown
Member

@vic vic commented Jul 15, 2025

No description provided.

Copilot AI review requested due to automatic review settings July 15, 2025 16:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the regen workflow into standalone shell‐application packages, updates an option type alias, and adjusts the CI workflow settings.

  • Change the Nix option type alias from lib.types.string to lib.types.str
  • Introduce oneach, each, and puke shell applications and simplify regen.nix to compose them
  • Update GitHub Actions to run on macOS and adjust nix run invocation flags

Reviewed Changes

Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.

File Description
modules/options.nix Switched option type from lib.types.string to lib.types.str
dev/modules/regen.nix Added oneach, each, puke wrappers and replaced inline regen logic with composition
.github/workflows/flake-check.yaml Changed runs-on to macos-latest and updated nix run commands
Comments suppressed due to low confidence (3)

.github/workflows/flake-check.yaml:8

  • [nitpick] Confirm that your Nix environment and dependencies work on macOS runners; if Linux is preferred for consistency, consider reverting to ubuntu-latest.
    runs-on: macos-latest

.github/workflows/flake-check.yaml:13

  • The trailing -- -L flag will be passed to your regen script rather than as a Nix override; remove or replace it with the intended --override-input flake-file "$PWD" flags.
      - run: nix run -L --override-input flake-file $PWD ./dev#regen -- -L

modules/options.nix:21

  • Verify that lib.types.str is a valid alias for string; if not, revert to lib.types.string or add an alias in lib/types.nix to avoid type errors.
    type = lib.types.str;

Comment thread dev/modules/regen.nix
@vic vic changed the title regen chore(regen): split into scripts. Jul 15, 2025
@vic vic merged commit 20bb391 into main Jul 15, 2025
1 check passed
@vic vic deleted the regen branch July 15, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants