Remove severity field from all rules by dennisdoomen · Pull Request #398 · dennisdoomen/CSharpGuidelines

dennisdoomen · 2026-05-14T10:20:47Z

Summary

The severity rating is no longer used or meaningful, so this PR removes it entirely.

Changes

130 rule files (_rules/*.md): removed the severity: N front matter field from each
_layouts/rule-category.html: removed the severity icon <img> tag that referenced {{ rule.severity }}.png
assets/images/1.png, 2.png, 3.png: deleted the now-unused severity images

* Add AV0110 guideline Split from #298. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Update _rules/0110.md Co-authored-by: Bart Koelman <10324372+bkoelman@users.noreply.github.com> --------- Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Bart Koelman <10324372+bkoelman@users.noreply.github.com>

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Add AV0120 guideline Split from #298. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Update _rules/0120.md Co-authored-by: Bart Koelman <10324372+bkoelman@users.noreply.github.com> * Update _rules/0120.md Co-authored-by: Bart Koelman <10324372+bkoelman@users.noreply.github.com> * Update _rules/0120.md Co-authored-by: Bart Koelman <10324372+bkoelman@users.noreply.github.com> --------- Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Bart Koelman <10324372+bkoelman@users.noreply.github.com>

Clarified the reasoning for preventing unnecessary coupling between components.

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…collection in a `foreach` loop (#363) * Update AV1530 guideline Split from #298. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address review comments on AV1530: update title and add foreach collection example Co-authored-by: dennisdoomen <572734+dennisdoomen@users.noreply.github.com> Agent-Logs-Url: https://github.com/dennisdoomen/CSharpGuidelines/sessions/983488b6-53b6-4360-876c-4576219b2d4f * Remove AV1530 rule file entirely Co-authored-by: dennisdoomen <572734+dennisdoomen@users.noreply.github.com> Agent-Logs-Url: https://github.com/dennisdoomen/CSharpGuidelines/sessions/0ce85de6-5278-491a-87c7-607ef017b67b --------- Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: dennisdoomen <572734+dennisdoomen@users.noreply.github.com>

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…325) * Add AV1615 guideline Split from #298. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Update _rules/1615.md Co-authored-by: Bart Koelman <10324372+bkoelman@users.noreply.github.com> --------- Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Bart Koelman <10324372+bkoelman@users.noreply.github.com>

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ow it does it (#330)

…tion scope (#328) * Add AV1622 guideline Split from #298. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Update _rules/1622.md Co-authored-by: Bart Koelman <10324372+bkoelman@users.noreply.github.com> --------- Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Bart Koelman <10324372+bkoelman@users.noreply.github.com>

…327)

…tialization (#319)

…l logic is needed (#316)

…he original type (#314)

)

… method (#312)

…s need (#309)

)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

The severity rating is no longer used. This removes: - The severity front matter field from all 130 rule files - The severity icon <img> from the rule-category layout - The unused severity images (1.png, 2.png, 3.png) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

dennisdoomen · 2026-05-14T10:46:37Z

@copilot resolve the merge conflicts in this pull request

Co-authored-by: dennisdoomen <572734+dennisdoomen@users.noreply.github.com>

Copilot · 2026-05-14T10:49:05Z

@copilot resolve the merge conflicts in this pull request

Resolved in commit 1bd7b0f. The only conflict was in Gemfile.lock (auto-generated). I took master's version, which brings in the latest security-patched dependencies (nokogiri 1.19.3, activesupport 7.2.3.1, etc.) along with the new AGENTS.md and .agents/skills/ files added to master.

Dennis Doomen and others added 30 commits February 16, 2026 18:49

Make sure the site works properly with Ruby 3.1

a0b0bea

Add AV0100: Understand the boundaries of your codebase (#300)

ad6370a

Add AV0105: Use design patterns to communicate intent (#301)

6899e40

Add AV0112: Apply the Principle of Least Surprise (#303)

7c15003

Add AV0115 guideline (#304)

8d36acd

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add AV0125: Don't Repeat Yourself (DRY) within boundaries (#306)

19f3c35

Update explanation of code boundaries and coupling

8ff5b65

Clarified the reasoning for preventing unnecessary coupling between components.

Add AV0135 guideline (#308)

7f005dc

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add AV1582 guideline (#318)

8d140f3

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add AV1608 guideline (#323)

9ebaced

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add AV1610 guideline (#324)

46c4087

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Update AV1708 guideline (#372)

7bd1063

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Update AV1562 guideline (#368)

76c7e50

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Update AV1800 guideline (#375)

a51fe48

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Update AV1521 guideline (#361)

792f093

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Update AV1520 guideline (#360)

4af00dc

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Update AV1140 guideline (#356)

b628a1a

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Update AV1250 guideline (#358)

3ffbfc8

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Update AV1115 guideline (#352)

196974d

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Update AV1025 guideline (#351)

b981cc1

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Update AV1020 guideline (#350)

9dc3c0e

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Update AV1011 guideline (#348)

25630e9

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Update AV1010 guideline (#347)

d57a494

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Update AV1003 guideline (#345)

bc2dafb

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add AV1618 guideline (#326)

360ac88

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Update AV1835 guideline (#378)

96303be

Split from #298. Co-authored-by: Dennis Doomen <dennis.doomen@greenchoice.nl> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

dennisdoomen and others added 22 commits May 10, 2026 10:11

Remove AV1737 guideline (#337)

dd11467

Remove AV1568 guideline (#336)

890a73b

Remove AV1532: Avoid nested loops (#334)

060ef45

Remove AV1525 guideline (#333)

f210e50

Remove AV1510 guideline (#332)

48e49e0

Remove AV1220 guideline (#331)

bfc3a86

Add AV2308: Document what a member tries to do, not what it does or h…

2d515fb

…ow it does it (#330)

Add AV2225: Use deconstruction to simplify variable assignments (#329)

566695e

Add AV1620: Test reusable components separately from their consumers (#…

22d1f03

…327)

Add AV1585: Make properties required when they must be set during ini…

380f20f

…tialization (#319)

Add AV1155: Use the field keyword in auto-properties when additiona…

6da5598

…l logic is needed (#316)

Add AV1150: Avoid local functions (#315)

454b59e

Add AV1145: Use extension members to add behavior without modifying t…

bb03ad5

…he original type (#314)

Add AV1035: Use primary constructors when they improve readability (#313

6fc3b6d

)

Add AV1032: Consider a delegate instead of an interface with a single…

619af9b

… method (#312)

Add AV1030: Know when to use a record and when to use a class (#311)

9d6a0d6

Add AV1002: Only pass things to a constructor that most or all member…

cde9d26

…s need (#309)

Remove AV2207 guideline (#340)

01259e1

Add AV0130: Apply the three pillars of object-oriented programming (#307

b3ee108

)

Fix c# fencing to use csharp in assertion-comparison.html

a3d7df4

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

dennisdoomen added the deprecated label May 14, 2026

Copilot started work on behalf of dennisdoomen May 14, 2026 10:46 View session

Merge master into remove-severity-from-rules to resolve conflicts

1bd7b0f

Co-authored-by: dennisdoomen <572734+dennisdoomen@users.noreply.github.com>

Copilot finished work on behalf of dennisdoomen May 14, 2026 10:50

dennisdoomen merged commit 243d23d into master May 14, 2026

dennisdoomen deleted the remove-severity-from-rules branch May 14, 2026 10:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove severity field from all rules#398

Remove severity field from all rules#398
dennisdoomen merged 92 commits into
masterfrom
remove-severity-from-rules

dennisdoomen commented May 14, 2026

Uh oh!

dennisdoomen commented May 14, 2026

Uh oh!

Copilot AI commented May 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dennisdoomen commented May 14, 2026

Summary

Changes

Uh oh!

dennisdoomen commented May 14, 2026

Uh oh!

Copilot AI commented May 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants