Skip to content

Conversation

@Soremwar
Copy link
Collaborator

@Soremwar Soremwar commented Dec 9, 2020

No description provided.

@Soremwar
Copy link
Collaborator Author

Soremwar commented Dec 9, 2020

@hayd Would you prefer the variables to be renamed to upper case or just lint ignore them?

@hayd
Copy link
Member

hayd commented Dec 9, 2020

Thanks @Soremwar! renaming is good.
I don't know if the Oid is case sensitive though?

@Soremwar
Copy link
Collaborator Author

Done @hayd
I renamed all variables to uppercase and opted for snake case in the oid

@Soremwar
Copy link
Collaborator Author

@hayd Can you give a quick review to this? 1.6.0 is really needed right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants