Skip to content

Conversation

@snsinfu
Copy link
Contributor

@snsinfu snsinfu commented Apr 3, 2021

This PR adds a support for scram-sha-256 authentication.

@snsinfu
Copy link
Contributor Author

snsinfu commented Apr 3, 2021

The checks seem to have failed due to a network error, but on my computer docker-compose up runs fine.

@Soremwar
Copy link
Collaborator

Soremwar commented Apr 3, 2021

I tried it locally in my machine and it didn't work either. This is I suspect a problem on how the Docker testing structure is currently executed. I'm gonna try and fix this upstream to make the tests pass

@Soremwar
Copy link
Collaborator

Soremwar commented Apr 3, 2021

I had to create a whole new container for scram authentication, since enabling scram would sadly disable authentication for both md5 and clear passwords

Copy link
Collaborator

@Soremwar Soremwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an incredible contribution @snsinfu
I have no further comments, though I will probably iterate over this in order to trim down some of the SHA utilities and replace them with the Deno builtin crypto that is likely to land in a couple weeks. Also I'd like to check if this works with SSL (I understand it's a slightly different protocol)

@Soremwar Soremwar merged commit 3f41b49 into denodrivers:master Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants