Skip to content

perf: re-use JSR metadata store across graph builds #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2025
Merged

perf: re-use JSR metadata store across graph builds #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44c3e16
feat: re-use JSR metadata store across graph builds
lucacasonato Sep 11, 2025
f399f10
fix
lucacasonato Sep 18, 2025
987e8a1
fix
lucacasonato Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deno
Open in desktop
Submodule deno updated 54 files
+4 −29 .github/workflows/ci.generate.ts
+4 −16 .github/workflows/ci.yml
+31 −20 Cargo.lock
+3 −3 Cargo.toml
+5 −5 cli/args/flags.rs
+5 −7 cli/factory.rs
+1 −0 cli/graph_util.rs
+5 −2 cli/lib/worker.rs
+4 −3 cli/lsp/config.rs
+69 −53 cli/main.rs
+5 −0 cli/schemas/config-file.v1.json
+99 −95 cli/tools/coverage/mod.rs
+1 −0 cli/tools/doc.rs
+2 −1 cli/tools/publish/unfurl.rs
+119 −13 cli/tools/repl/session.rs
+187 −117 cli/tools/run/hmr.rs
+2 −2 cli/tools/task.rs
+2 −9 cli/tools/test/mod.rs
+33 −60 cli/worker.rs
+28 −20 ext/fetch/lib.rs
+14 −59 ext/http/00_serve.ts
+0 −1 ext/http/01_http.js
+27 −3 ext/http/02_websocket.ts
+1 −0 ext/http/Cargo.toml
+133 −118 ext/http/http_next.rs
+0 −2 ext/http/lib.rs
+0 −362 ext/http/websocket_upgrade.rs
+2 −2 ext/net/ops_tls.rs
+192 −91 ext/net/raw.rs
+2 −1 ext/node/lib.rs
+35 −3 ext/node/ops/fs.rs
+51 −141 ext/node/ops/http.rs
+30 −29 ext/node/ops/inspector.rs
+0 −56 ext/node/polyfills/_fs/_fs_statfs.js
+172 −0 ext/node/polyfills/_fs/_fs_statfs.ts
+1 −1 ext/node/polyfills/fs.ts
+9 −10 ext/node/polyfills/http.ts
+23 −2 ext/node/polyfills/internal_binding/_timingSafeEqual.ts
+2 −3 ext/websocket/01_websocket.js
+2 −0 ext/websocket/lib.rs
+10 −2 runtime/worker.rs
+4 −1 tests/integration/coverage_tests.rs
+2 −0 tests/integration/inspector_tests.rs
+1 −0 tests/integration/node_unit_tests.rs
+1 −0 tests/node_compat/config.toml
+2 −1 tests/specs/run/tunnel/test.out
+6 −1 tests/specs/run/tunnel/test.ts
+19 −7 tests/unit/serve_test.ts
+37 −4 tests/unit_node/_fs/_fs_statfs_test.ts
+39 −0 tests/unit_node/crypto/crypto_timing_safe_equal_test.ts
+9 −4 tests/unit_node/http_test.ts
+8 −0 tests/util/server/src/servers/ws.rs
+1 −0 tools/core_import_map.json
+1 −4 tools/release/create_symcache.ts
16 changes: 8 additions & 8 deletions src/rs_lib/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/rs_lib/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ path = "../../deno/libs/config"
features = ["workspace","sync"]

[dependencies.deno_graph]
version = "=0.100.0"
version = "=0.100.1"
features = ["swc"]
default-features = false

Expand Down
4 changes: 4 additions & 0 deletions src/rs_lib/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ use deno_cache_dir::file_fetcher::NullBlobStore;
use deno_error::JsErrorBox;
use deno_graph::CheckJsOption;
use deno_graph::GraphKind;
use deno_graph::JsrMetadataStore;
use deno_graph::MediaType;
use deno_graph::ModuleGraph;
use deno_graph::Position;
Expand Down Expand Up @@ -381,6 +382,7 @@ impl DenoWorkspace {
graph: ModuleGraphCell::new(deno_graph::ModuleGraph::new(
deno_graph::GraphKind::CodeOnly,
)),
jsr_metadata_store: Rc::new(JsrMetadataStore::default()),
})
}
}
Expand All @@ -401,6 +403,7 @@ pub struct DenoLoader {
workspace_factory: Arc<WorkspaceFactory<RealSys>>,
graph: ModuleGraphCell,
task_queue: Rc<deno_unsync::TaskQueue>,
jsr_metadata_store: Rc<JsrMetadataStore>,
}

impl Drop for DenoLoader {
Expand Down Expand Up @@ -527,6 +530,7 @@ impl DenoLoader {
resolver: Some(&graph_resolver),
unstable_bytes_imports: true,
unstable_text_imports: true,
jsr_metadata_store: Some(self.jsr_metadata_store.clone()),
},
)
.await;
Expand Down
Loading