Skip to content

Commit 007bda5

Browse files
divybotlittledivy
andauthored
ci: fix npm_publish pnpm install failing under strict-dep-builds (#34445)
Co-authored-by: divybot <divybot@users.noreply.github.com> Co-authored-by: Divy Srivastava <me@littledivy.com>
1 parent 6783347 commit 007bda5

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

.github/workflows/npm_publish.generated.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,14 +188,14 @@ jobs:
188188
cd "$TEST_DIR"
189189
npm init -y
190190
EXPECTED_VERSION="deno ${{ steps.publish-verdaccio.outputs.version }}"
191-
pnpm install deno@${{ steps.publish-verdaccio.outputs.version }} --registry http://localhost:4873/
191+
pnpm install --ignore-scripts deno@${{ steps.publish-verdaccio.outputs.version }} --registry http://localhost:4873/
192192
ACTUAL="$(node node_modules/deno/bin.cjs -v)"
193193
echo "$ACTUAL"
194194
[ "$ACTUAL" = "$EXPECTED_VERSION" ] || { echo "Version mismatch: expected '$EXPECTED_VERSION', got '$ACTUAL'"; exit 1; }
195195
- name: Test pnpm global install deno (without postinstall)
196196
run: |-
197197
EXPECTED_VERSION="deno ${{ steps.publish-verdaccio.outputs.version }}"
198-
pnpm install -g deno@${{ steps.publish-verdaccio.outputs.version }} --registry http://localhost:4873/
198+
pnpm install -g --ignore-scripts deno@${{ steps.publish-verdaccio.outputs.version }} --registry http://localhost:4873/
199199
ACTUAL="$(node "$PNPM_HOME/global/5/node_modules/deno/bin.cjs" -v)"
200200
echo "$ACTUAL"
201201
[ "$ACTUAL" = "$EXPECTED_VERSION" ] || { echo "Version mismatch: expected '$EXPECTED_VERSION', got '$ACTUAL'"; exit 1; }

.github/workflows/npm_publish.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ const testPnpmLocalNoScripts = step.dependsOn(testNpmGlobalIgnoreScripts)({
245245
'cd "$TEST_DIR"',
246246
"npm init -y",
247247
'EXPECTED_VERSION="deno ${{ steps.publish-verdaccio.outputs.version }}"',
248-
"pnpm install deno@${{ steps.publish-verdaccio.outputs.version }} --registry http://localhost:4873/",
248+
"pnpm install --ignore-scripts deno@${{ steps.publish-verdaccio.outputs.version }} --registry http://localhost:4873/",
249249
'ACTUAL="$(node node_modules/deno/bin.cjs -v)"',
250250
'echo "$ACTUAL"',
251251
'[ "$ACTUAL" = "$EXPECTED_VERSION" ] || { echo "Version mismatch: expected \'$EXPECTED_VERSION\', got \'$ACTUAL\'"; exit 1; }',
@@ -256,7 +256,7 @@ const testPnpmGlobalNoScripts = step.dependsOn(testPnpmLocalNoScripts)({
256256
name: "Test pnpm global install deno (without postinstall)",
257257
run: [
258258
'EXPECTED_VERSION="deno ${{ steps.publish-verdaccio.outputs.version }}"',
259-
"pnpm install -g deno@${{ steps.publish-verdaccio.outputs.version }} --registry http://localhost:4873/",
259+
"pnpm install -g --ignore-scripts deno@${{ steps.publish-verdaccio.outputs.version }} --registry http://localhost:4873/",
260260
'ACTUAL="$(node "$PNPM_HOME/global/5/node_modules/deno/bin.cjs" -v)"',
261261
'echo "$ACTUAL"',
262262
'[ "$ACTUAL" = "$EXPECTED_VERSION" ] || { echo "Version mismatch: expected \'$EXPECTED_VERSION\', got \'$ACTUAL\'"; exit 1; }',

0 commit comments

Comments
 (0)