Skip to content

Commit 1287800

Browse files
authored
fix(ext/node): rename _destroySsl to _destroySSL to match Node.js API (#33599)
- Renames `TLSSocket.prototype._destroySsl` to `_destroySSL` to match Node.js's naming convention - Fixes `test-tls-socket-destroy.js` node_compat test which calls `socket._destroySSL()` and was getting `TypeError: not a function`
1 parent 3be0a6f commit 1287800

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

ext/node/polyfills/_tls_wrap.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,7 @@ function defineHandleReading(socket, handle) {
442442
});
443443
}
444444

445-
TLSSocket.prototype._destroySsl = function _destroySsl() {
445+
TLSSocket.prototype._destroySSL = function _destroySSL() {
446446
if (!this.ssl) return;
447447
this.ssl.destroySsl();
448448
this.ssl = null;

tests/node_compat/config.jsonc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3128,6 +3128,7 @@
31283128
"parallel/test-tls-snicallback-error.js": {},
31293129
"parallel/test-tls-socket-allow-half-open-option.js": {},
31303130
"parallel/test-tls-socket-constructor-alpn-options-parsing.js": {},
3131+
"parallel/test-tls-socket-destroy.js": {},
31313132
"parallel/test-tls-timeout-server-2.js": {},
31323133
"parallel/test-tls-tlswrap-segfault-2.js": {},
31333134
"parallel/test-tls-transport-destroy-after-own-gc.js": {},

0 commit comments

Comments
 (0)