feat: v8 14.9 (#34226)

Author: bartlomieju

Cargo.lock

@@ -102,7 +102,7 @@ deno_task_shell = "=0.30.0"
 deno_terminal = "=0.2.3"
 deno_unsync = { version = "0.4.4", default-features = false }
 deno_whoami = "0.1.0"
-v8 = { version = "147.4.0", default-features = false, features = ["simdutf"] }
+v8 = { version = "149.0.0", default-features = false, features = ["simdutf"] }
 
 denokv_proto = "0.13.0"
 denokv_remote = "0.13.0"

Cargo.toml

@@ -2,7 +2,6 @@
 
 use std::path::Path;
 use std::path::PathBuf;
-use std::rc::Rc;
 use std::sync::Arc;
 
 use ::tokio_util::sync::CancellationToken;
@@ -121,8 +120,8 @@ impl PluginHostProxy {
 
 pub struct PluginHost {
   worker: MainWorker,
-  install_plugins_fn: Rc<v8::Global<v8::Function>>,
-  run_plugins_for_file_fn: Rc<v8::Global<v8::Function>>,
+  install_plugins_fn: v8::Global<v8::Function>,
+  run_plugins_for_file_fn: v8::Global<v8::Function>,
   rx: mpsc::Receiver<PluginHostRequest>,
 }
 
@@ -194,8 +193,8 @@ async fn create_plugin_runner_inner(
       run_plugins_for_file_fn_val.try_into().unwrap();
 
     (
-      Rc::new(v8::Global::new(scope, install_plugins_fn)),
-      Rc::new(v8::Global::new(scope, run_plugins_for_file_fn)),
+      v8::Global::new(scope, install_plugins_fn),
+      v8::Global::new(scope, run_plugins_for_file_fn),
     )
   };
 
@@ -344,7 +343,7 @@ impl PluginHost {
         .unwrap()
         .into();
     let run_plugins_for_file =
-      v8::Local::new(scope, &*self.run_plugins_for_file_fn);
+      v8::Local::new(scope, &self.run_plugins_for_file_fn);
     let undefined = v8::undefined(scope);
 
     let _run_plugins_result = {
@@ -402,8 +401,7 @@ impl PluginHost {
     }
 
     deno_core::scope!(scope, &mut self.worker.js_runtime);
-    let install_plugins_local =
-      v8::Local::new(scope, &*self.install_plugins_fn.clone());
+    let install_plugins_local = v8::Local::new(scope, &self.install_plugins_fn);
     let exclude_v8: v8::Local<v8::Value> =
       exclude.map_or(v8::null(scope).into(), |v| {
         let elems = v

cli/tools/lint/plugins.rs

@@ -632,7 +632,6 @@ class NodeWorker extends EventEmitter {
       switch (type) {
         case 1: { // TerminalError
           this.#status = "CLOSED";
-          this.#closeStdio();
           if (this.listenerCount("error") > 0) {
             const errMsg = data.errorMessage ?? data.message;
             const errName = data.name;
@@ -652,9 +651,13 @@ class NodeWorker extends EventEmitter {
             err.stack = undefined;
             this.emit("error", err);
           }
-          // Drain pending messages before emitting exit so that
-          // all 'message' events fire before 'exit' (Node.js behavior).
+          // Drain pending messages before closing stdio and emitting exit:
+          // any stdio chunks still queued on the message channel must be
+          // pushed onto the Readable streams *before* we EOF them, otherwise
+          // we hit "stream.push() after EOF" if the Close control arrives
+          // before the last stdout/stderr message (Node.js behavior).
           await this.#messageLoopPromise;
+          this.#closeStdio();
           this.resourceLimits = {};
           if (!this.#exited) {
             this.#exited = true;
@@ -669,10 +672,13 @@ class NodeWorker extends EventEmitter {
         case 3: { // Close
           debugWT(`Host got "close" message from worker: ${this.#name}`);
           this.#status = "CLOSED";
-          this.#closeStdio();
-          // Drain pending messages before emitting exit so that
-          // all 'message' events fire before 'exit' (Node.js behavior).
+          // Drain pending messages before closing stdio and emitting exit:
+          // any stdio chunks still queued on the message channel must be
+          // pushed onto the Readable streams *before* we EOF them, otherwise
+          // we hit "stream.push() after EOF" if the Close control arrives
+          // before the last stdout/stderr message (Node.js behavior).
           await this.#messageLoopPromise;
+          this.#closeStdio();
           this.resourceLimits = {};
           if (!this.#exited) {
             this.#exited = true;

ext/node/polyfills/worker_threads.ts

@@ -1146,9 +1146,7 @@ impl ModuleMap {
       );
     };
     let wasm_module_object: v8::Local<v8::Object> = wasm_module.into();
-    let wasm_module_object_global = v8::Global::new(scope, wasm_module_object);
-
-    let source = Rc::new(wasm_module_object_global);
+    let source = v8::Global::new(scope, wasm_module_object);
     {
       let mut data = self.data.borrow_mut();
       data.sources.insert(reference_key, source.clone());
@@ -1423,7 +1421,7 @@ impl ModuleMap {
     };
     let key = ModuleSourceKey::from_reference(&module_reference);
     if let Some(entry) = module_map.data.borrow().sources.get(&key) {
-      Some(v8::Local::new(scope, entry.as_ref()))
+      Some(v8::Local::new(scope, entry))
     } else {
       let message = v8::String::new(
         scope,
@@ -2504,7 +2502,7 @@ impl ModuleMap {
               let key = ModuleSourceKey::from_reference(module_reference);
               let source = {
                 let data = self.data.borrow();
-                let source = data.sources.get(&key).expect("Source had to have been inserted successfully, or recursion would error.").as_ref();
+                let source = data.sources.get(&key).expect("Source had to have been inserted successfully, or recursion would error.");
                 v8::Local::new(scope, source).into()
               };
               let resolver = state.resolver.open(scope);

libs/core/modules/map.rs

@@ -231,7 +231,7 @@ pub(crate) struct ModuleMapData {
   /// the `synthetic_esm` dispatch goes straight through Rust without the
   /// JS `core.loadExtScript` wrapper. Runtime-only — not snapshotted.
   pub(crate) captured_bootstrap: RefCell<Option<v8::Global<v8::Value>>>,
-  pub(crate) sources: HashMap<ModuleSourceKey, Rc<v8::Global<v8::Object>>>,
+  pub(crate) sources: HashMap<ModuleSourceKey, v8::Global<v8::Object>>,
   /// Specifiers of `lazy_loaded_esm` / `lazy_loaded_js` files whose source
   /// was actually compiled by V8 during snapshot creation. Their bytes live
   /// in the snapshot blob; the binary does not need a separate copy.

libs/core/modules/module_map_data.rs

@@ -104,11 +104,10 @@ pub unsafe extern "C" fn slow_metrics_dispatch(
 ) {
   // SAFETY: info is a valid pointer from V8
   let info_ref = unsafe { &*info };
-  let args =
-    v8::FunctionCallbackArguments::from_function_callback_info(info_ref);
+  let parts = info_ref.get_parts();
   // SAFETY: data is always an External pointing to OpCtx
   let opctx: &OpCtx = unsafe {
-    &*(v8::Local::<v8::External>::cast_unchecked(args.data()).value()
+    &*(v8::Local::<v8::External>::cast_unchecked(parts.data).value()
       as *const OpCtx)
   };