fix(ext/node): align module.builtinModules / getBuiltinModule with Node (#33404)

Co-authored-by: Nathan Whitaker <nathan@deno.com>

Author: nathanwhitbot

ext/node/polyfills/01_require.js

@@ -54,7 +54,9 @@ const {
   RegExpPrototypeTest,
   SafeArrayIterator,
   SafeMap,
+  SafeSet,
   SafeWeakMap,
+  SetPrototypeHas,
   String,
   StringPrototypeCharCodeAt,
   StringPrototypeEndsWith,
@@ -275,7 +277,7 @@ function setupBuiltinModules() {
     timers,
     "timers/promises": timersPromises,
     tls,
-    traceEvents,
+    trace_events: traceEvents,
     tty,
     url,
     util,
@@ -286,9 +288,27 @@ function setupBuiltinModules() {
     worker_threads: workerThreads,
     zlib,
   };
+  // Match Node's schemelessBlockList: these modules can only be imported
+  // via the `node:` scheme (see lib/internal/bootstrap/realm.js), so they
+  // appear in `builtinModules` as `node:<name>` rather than `<name>`.
+  const schemelessBlockList = new SafeSet([
+    "sea",
+    "sqlite",
+    "test",
+    "test/reporters",
+  ]);
   for (const [name, moduleExports] of ObjectEntries(nodeModules)) {
     nativeModuleExports[name] = moduleExports;
-    ArrayPrototypePush(builtinModules, name);
+    // `internal/*` modules are only exposed under --expose-internals, so
+    // they aren't part of the public builtinModules list.
+    if (StringPrototypeStartsWith(name, "internal/")) {
+      continue;
+    }
+    if (SetPrototypeHas(schemelessBlockList, name)) {
+      ArrayPrototypePush(builtinModules, `node:${name}`);
+    } else {
+      ArrayPrototypePush(builtinModules, name);
+    }
   }
 }
 setupBuiltinModules();
@@ -1372,6 +1392,9 @@ function isBuiltin(moduleName) {
 }
 
 function getBuiltinModule(id) {
+  if (typeof id !== "string") {
+    throw new internalErrors.ERR_INVALID_ARG_TYPE("id", "string", id);
+  }
   if (!isBuiltin(id)) {
     return undefined;
   }

tests/node_compat/config.jsonc

@@ -1994,6 +1994,7 @@
     "parallel/test-process-exit-recursive.js": {},
     "parallel/test-process-exit.js": {},
     "parallel/test-process-features.js": {},
+    "parallel/test-process-get-builtin.mjs": {},
     "parallel/test-process-getgroups.js": {},
     "parallel/test-process-hrtime-bigint.js": {},
     "parallel/test-process-hrtime.js": {},
@@ -2558,13 +2559,25 @@
     "parallel/test-tls-transport-destroy-after-own-gc.js": {},
     "parallel/test-tls-wrap-econnreset-pipe.js": { "windows": false },
     "parallel/test-tls-zero-clear-in.js": {},
-    "parallel/test-trace-events-api.js": {},
-    "parallel/test-trace-events-async-hooks-dynamic.js": {},
-    "parallel/test-trace-events-async-hooks-worker.js": {},
+    "parallel/test-trace-events-api.js": {
+      "ignore": true,
+      "reason": "Deno's node:trace_events polyfill is a stub (createTracing returns an object without .enable/.disable, getEnabledCategories returns \"\" instead of undefined). These tests were silently skipping via try/catch(require('trace_events')) until that lookup was fixed."
+    },
+    "parallel/test-trace-events-async-hooks-dynamic.js": {
+      "ignore": true,
+      "reason": "Deno's node:trace_events polyfill is a stub (createTracing returns an object without .enable/.disable, getEnabledCategories returns \"\" instead of undefined). These tests were silently skipping via try/catch(require('trace_events')) until that lookup was fixed."
+    },
+    "parallel/test-trace-events-async-hooks-worker.js": {
+      "ignore": true,
+      "reason": "Deno's node:trace_events polyfill is a stub (createTracing returns an object without .enable/.disable, getEnabledCategories returns \"\" instead of undefined). These tests were silently skipping via try/catch(require('trace_events')) until that lookup was fixed."
+    },
     "parallel/test-trace-events-dynamic-enable-workers-disabled.js": {},
     // TODO(bartlomieju): disabled during work on `node:inspector`, this test didn't actualy run before
     // "parallel/test-trace-events-dynamic-enable.js": {},
-    "parallel/test-trace-events-get-category-enabled-buffer.js": {},
+    "parallel/test-trace-events-get-category-enabled-buffer.js": {
+      "ignore": true,
+      "reason": "Deno's node:trace_events polyfill is a stub (createTracing returns an object without .enable/.disable, getEnabledCategories returns \"\" instead of undefined). These tests were silently skipping via try/catch(require('trace_events')) until that lookup was fixed."
+    },
     "parallel/test-tty-stdin-end.js": {},
     "parallel/test-tty-stdin-pipe.js": {},
     "parallel/test-ttywrap-invalid-fd.js": {},