fix(test): do not report "only" notice when a test fails on its own (#35063)

Fixes #28648

Author: crowlbot

cli/tools/test/mod.rs

@@ -1710,17 +1710,20 @@ pub async fn report_tests(
     );
   }
 
+  // A genuine test failure takes precedence over the `only` notice: if a test
+  // failed on its own, reporting that it failed "because the \"only\" option
+  // was used" is misleading.
+  if failed {
+    return (Err(anyhow!("Test failed")), receiver);
+  }
+
   if used_only {
     return (
       Err(anyhow!("Test failed because the \"only\" option was used",)),
       receiver,
     );
   }
 
-  if failed {
-    return (Err(anyhow!("Test failed")), receiver);
-  }
-
   (Ok(()), receiver)
 }
 

tests/specs/test/only_failed/__test__.jsonc

@@ -0,0 +1,14 @@
+{
+  "tests": {
+    "only_test_fails_on_its_own": {
+      "args": "test --no-check main.ts",
+      "exitCode": 1,
+      "output": "main.out"
+    },
+    "only_test_passes": {
+      "args": "test --no-check pass.ts",
+      "exitCode": 1,
+      "output": "pass.out"
+    }
+  }
+}

tests/specs/test/only_failed/main.out

@@ -0,0 +1,18 @@
+running 1 test from ./main.ts
+fails on its own ... FAILED ([WILDCARD])
+
+ ERRORS 
+
+fails on its own => ./main.ts:3:11
+error: Error: boom
+  throw new Error("boom");
+        ^
+    at [WILDCARD]main.ts:4:9
+
+ FAILURES 
+
+fails on its own => ./main.ts:3:11
+
+FAILED | 0 passed | 1 failed ([WILDCARD])
+
+error: Test failed

tests/specs/test/only_failed/main.ts

@@ -0,0 +1,5 @@
+// When a test marked with `only` fails on its own, the run should report the
+// actual failure rather than the misleading "only" notice.
+Deno.test.only("fails on its own", () => {
+  throw new Error("boom");
+});

tests/specs/test/only_failed/pass.out

@@ -0,0 +1,6 @@
+running 1 test from ./pass.ts
+passes ... ok ([WILDCARD])
+
+ok | 1 passed | 0 failed ([WILDCARD])
+
+error: Test failed because the "only" option was used

tests/specs/test/only_failed/pass.ts

@@ -0,0 +1,3 @@
+// A `only` test that passes should still report the "only" notice, since the
+// run only "failed" because the `only` filter was applied.
+Deno.test.only("passes", () => {});