Commit 749270f
authored
fix(ext/node): include prototype env vars in child_process spawn (#32699)
The env key collection loop had `Object.hasOwn()` filtering despite the
comment saying "Prototype values are intentionally included". This made
`for...in` pointless since it only kept own properties.
Node.js includes prototype-chain env vars when spawning child processes,
and this test explicitly verifies that behavior.1 parent b177ff6 commit 749270f
2 files changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1148 | 1148 | | |
1149 | 1149 | | |
1150 | 1150 | | |
| 1151 | + | |
1151 | 1152 | | |
1152 | | - | |
1153 | | - | |
1154 | | - | |
| 1153 | + | |
1155 | 1154 | | |
1156 | 1155 | | |
1157 | 1156 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
205 | 205 | | |
206 | 206 | | |
207 | 207 | | |
| 208 | + | |
208 | 209 | | |
209 | 210 | | |
210 | 211 | | |
| |||
0 commit comments