refactor: remove Node/Deno global proxy and simplify CJS wrapper (#33122)

## Summary

- Remove the v8 named property handler proxy in `ext/node/global.rs`
that intercepted `process` and `window` global accesses based on
Node/Deno context
- Now that Node.js timers are the default (#33118), the only remaining
managed globals were `process` (already set directly on `globalThis`)
and `window` (never populated in `denoGlobals`), making the proxy a
no-op
- Simplify the CJS module wrapper to match Node.js — no longer
destructures globals from `Deno[Deno.internal].nodeGlobals` since
they're all on `globalThis`
- Remove the `nodeGlobals` bag from `02_init.js` and `99_main.js`
entirely

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: bartlomieju

ext/node/global.rs

@@ -29,7 +29,6 @@ use node_resolver::errors::PackageJsonLoadError;
 
 extern crate libz_sys as zlib;
 
-mod global;
 pub mod ops;
 
 use deno_dotenv::parse_env_content_hook;
@@ -44,10 +43,6 @@ pub use ops::vm::VM_CONTEXT_INDEX;
 pub use ops::vm::create_v8_context;
 pub use ops::vm::init_global_template;
 
-pub use crate::global::GlobalsStorage;
-use crate::global::global_object_middleware;
-use crate::global::global_template_middleware;
-
 pub fn is_builtin_node_module(module_name: &str) -> bool {
   DenoIsBuiltInNodeModuleChecker.is_builtin_node_module(module_name)
 }
@@ -374,7 +369,6 @@ deno_core::extension!(deno_node,
   esm_entry_point = "ext:deno_node/02_init.js",
   esm = [
     dir "polyfills",
-    "00_globals.js",
     "02_init.js",
     "_events.mjs",
     "internal/fs/promises.ts",
@@ -616,8 +610,6 @@ deno_core::extension!(deno_node,
     }
 
   },
-  global_template_middleware = global_template_middleware,
-  global_object_middleware = global_object_middleware,
   customizer = |ext: &mut deno_core::Extension| {
     let external_references = [
       vm::QUERY_MAP_FN.with(|query| {
@@ -692,41 +684,6 @@ deno_core::extension!(deno_node,
         }
       }),
 
-      global::GETTER_MAP_FN.with(|getter| {
-        ExternalReference {
-          named_getter: *getter,
-        }
-      }),
-      global::SETTER_MAP_FN.with(|setter| {
-        ExternalReference {
-          named_setter: *setter,
-        }
-      }),
-      global::QUERY_MAP_FN.with(|query| {
-        ExternalReference {
-          named_query: *query,
-        }
-      }),
-      global::DELETER_MAP_FN.with(|deleter| {
-        ExternalReference {
-          named_deleter: *deleter,
-        }
-      }),
-      global::ENUMERATOR_MAP_FN.with(|enumerator| {
-        ExternalReference {
-          enumerator: *enumerator,
-        }
-      }),
-      global::DEFINER_MAP_FN.with(|definer| {
-        ExternalReference {
-          named_definer: *definer,
-        }
-      }),
-      global::DESCRIPTOR_MAP_FN.with(|descriptor| {
-        ExternalReference {
-          named_getter: *descriptor,
-        }
-      }),
     ];
 
     ext.external_references.to_mut().extend(external_references);

ext/node/lib.rs

@@ -628,7 +628,11 @@ pub fn init_global_template<'a>(
 
 // Using thread_local! to get around compiler bug.
 //
-// See NOTE in ext/node/global.rs#L12
+// NOTE(bartlomieju): somehow calling `.map_fn_to()` multiple times on a
+// function returns two different pointers. That shouldn't be the case as
+// `.map_fn_to()` creates a thin wrapper that is a pure function.
+// @piscisaureus suggests it might be a bug in Rust compiler; so for now we
+// just create and store these mapped functions per-thread.
 thread_local! {
   pub static QUERY_MAP_FN: v8::NamedPropertyQueryCallback = property_query.map_fn_to();
   pub static GETTER_MAP_FN: v8::NamedPropertyGetterCallback = property_getter.map_fn_to();

ext/node/ops/vm.rs

@@ -962,14 +962,9 @@ Module.prototype.require = function (id) {
   }
 };
 
-// The module wrapper looks slightly different to Node. Instead of using one
-// wrapper function, we use two. The first one exists to performance optimize
-// access to magic node globals, like `Buffer`. The second one is the actual
-// wrapper function we run the users code in. The only observable difference is
-// that in Deno `arguments.callee` is not null.
 const wrapper = [
-  `(function (exports, require, module, __filename, __dirname) { var { Buffer, clearImmediate, global, process, setImmediate } = Deno[Deno.internal].nodeGlobals; (() => {`,
-  "\n})(); })",
+  "(function (exports, require, module, __filename, __dirname) { ",
+  "\n});",
 ];
 
 export let wrap = function (script) {

ext/node/polyfills/00_globals.js

@@ -6,7 +6,6 @@ import { core, internals } from "ext:core/mod.js";
 const requireImpl = internals.requireImpl;
 
 import { op_stream_base_register_state } from "ext:core/ops";
-import { nodeGlobals } from "ext:deno_node/00_globals.js";
 import {
   kStreamBaseField,
   streamBaseState,
@@ -151,12 +150,6 @@ internals.node = {
 };
 
 const nativeModuleExports = requireImpl.nativeModuleExports;
-nodeGlobals.Buffer = nativeModuleExports["buffer"].Buffer;
-nodeGlobals.clearImmediate = nativeModuleExports["timers"].clearImmediate;
-nodeGlobals.global = globalThis;
-nodeGlobals.process = nativeModuleExports["process"];
-nodeGlobals.setImmediate = nativeModuleExports["timers"].setImmediate;
-
 nativeModuleExports["internal/console/constructor"].bindStreamsLazy(
   nativeModuleExports["console"],
   nativeModuleExports["process"],

ext/node/polyfills/01_require.js

@@ -93,7 +93,6 @@ import {
 } from "ext:runtime/98_global_scope_worker.js";
 import { SymbolMetadata } from "ext:deno_web/00_infra.js";
 import { bootstrap as bootstrapOtel } from "ext:deno_telemetry/telemetry.ts";
-import { nodeGlobals } from "ext:deno_node/00_globals.js";
 
 // deno-lint-ignore prefer-primordials
 if (Symbol.metadata) {
@@ -561,7 +560,7 @@ function removeImportedOps() {
 // FIXME(bartlomieju): temporarily add whole `Deno.core` to
 // `Deno[Deno.internal]` namespace. It should be removed and only necessary
 // methods should be left there.
-ObjectAssign(internals, { core, nodeGlobals: { ...nodeGlobals } });
+ObjectAssign(internals, { core });
 const internalSymbol = Symbol("Deno.internal");
 const finalDenoNs = {
   internal: internalSymbol,

ext/node/polyfills/02_init.js

@@ -554,7 +554,6 @@
     "ext:deno_node/_util/std_fmt_colors.ts": "../ext/node/polyfills/_util/std_fmt_colors.ts",
     "ext:deno_node/_utils.ts": "../ext/node/polyfills/_utils.ts",
     "ext:deno_node/_zlib_binding.mjs": "../ext/node/polyfills/_zlib_binding.mjs",
-    "ext:deno_node/00_globals.js": "../ext/node/polyfills/00_globals.js",
     "ext:deno_node/inspector.ts": "../ext/node/polyfills/inspector.ts",
     "ext:deno_node/internal_binding/_libuv_winerror.ts": "../ext/node/polyfills/internal_binding/_libuv_winerror.ts",
     "ext:deno_node/internal_binding/_listen.ts": "../ext/node/polyfills/internal_binding/_listen.ts",