Skip to content

Commit 8266125

Browse files
authored
fix(core): disable include_icu_data feature (#34279)
This change denoland/rusty_v8@12d7ef1#diff-b2b1f3ec619c03c5bba2f171beab1301d960e1dcac6a17a99ce02326ce9c49b4R83 made it so icu data is bundled in with v8 unconditionally, so we don't need to include the copy from deno_core anymore. Resolves a roughly 11MB regression in binary size with the v8 upgrade.
1 parent 85e85c4 commit 8266125

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

libs/core/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ description = "A modern JavaScript/TypeScript runtime built with V8, Rust, and T
1414
path = "lib.rs"
1515

1616
[features]
17-
default = ["include_icu_data", "v8_use_custom_libcxx", "reactor-tokio"]
17+
default = ["v8_use_custom_libcxx", "reactor-tokio"]
1818
reactor-tokio = []
1919
include_icu_data = ["deno_core_icudata"]
2020
v8_use_custom_libcxx = ["v8/use_custom_libcxx"]

0 commit comments

Comments
 (0)