fix(ext/node): throw ERR_UNKNOWN_BUILTIN_MODULE for unknown node: builtins (#34766)

Node's CommonJS loader throws `ERR_UNKNOWN_BUILTIN_MODULE` (with message
`No such built-in module: <id>`) when `require()` is given a
`node:`-prefixed specifier that is not a public builtin. Two cases were
handled incorrectly:

1. `require("node:unknown")` threw a generic `MODULE_NOT_FOUND` `Error`
instead of `ERR_UNKNOWN_BUILTIN_MODULE`.
2. `require("node:internal/...")` resolved to Deno's internal polyfill
modules. Node only exposes `internal/*` builtins under
`--expose-internals`, so from userland these should be treated as
unknown. This matches the existing `isBuiltin()` check and the public
`builtinModules` list, both of which already exclude `internal/*`.

This changes the `node:`-scheme branch of `Module._resolveFilename` to
skip `internal/*` ids and to throw
`internalErrors.ERR_UNKNOWN_BUILTIN_MODULE`. Bare (non-`node:`-prefixed)
`require("internal/...")` is intentionally left unchanged.

Enables the upstream test `parallel/test-require-node-prefix.js`.

Author: crowlbot

ext/node/polyfills/01_require.js

@@ -1375,6 +1375,25 @@ Module._resolveLookupPaths = function (request, parent) {
 };
 
 Module._load = function (request, parent, isMain) {
+  // A `node:`-prefixed `require()` of a specifier that isn't a user-requirable
+  // builtin throws ERR_UNKNOWN_BUILTIN_MODULE. This covers unknown ids and
+  // `internal/*` modules (Node only exposes those under `--expose-internals`).
+  // `require.resolve()` goes through `_resolveFilename` directly and instead
+  // reports MODULE_NOT_FOUND, so this check lives here rather than there.
+  if (
+    typeof request === "string" &&
+    StringPrototypeStartsWith(request, "node:") &&
+    !(hookEntries.length > 0 && !insideResolveHook)
+  ) {
+    const id = StringPrototypeSlice(request, 5);
+    if (
+      !(id in nativeModuleExports) ||
+      StringPrototypeStartsWith(id, "internal/")
+    ) {
+      throw new internalErrors.ERR_UNKNOWN_BUILTIN_MODULE(request);
+    }
+  }
+
   let relResolveCacheIdentifier;
   if (parent) {
     // Fast path for (lazy loaded) modules in the same directory. The indirect
@@ -1675,6 +1694,9 @@ Module._resolveFilename = function (
     if (hookEntries.length > 0 && !insideResolveHook) {
       return request;
     }
+    // `require.resolve("node:unknown")` reports MODULE_NOT_FOUND, unlike
+    // `require("node:unknown")` which throws ERR_UNKNOWN_BUILTIN_MODULE from
+    // `Module._load`.
     const err = new Error(`Cannot find module '${request}'`);
     err.code = "MODULE_NOT_FOUND";
     throw err;

tests/node_compat/config.jsonc

@@ -3111,6 +3111,7 @@
     "parallel/test-require-invalid-package.js": {},
     "parallel/test-require-json.js": {},
     "parallel/test-require-long-path.js": {},
+    "parallel/test-require-node-prefix.js": {},
     "parallel/test-require-nul.js": {},
     "parallel/test-require-process.js": {},
     "parallel/test-require-resolve.js": {},