Skip to content

Commit a9bc206

Browse files
divybotlittledivy
andauthored
chore: mark parallel/test-shadow-realm-* as ignored (#34155)
## Summary Per maintainer feedback (#34155 review), the TC39 ShadowRealm proposal is still at Stage 2.7 with limited recent progress, so exposing it globally is premature. This PR instead skips the eight failing `parallel/test-shadow-realm-*` node compat tests with an `ignore` reason in `config.jsonc` so they no longer count against the suite. Closes denoland/orchid#118 ## Test plan - [x] `./tools/format.js` and `./tools/lint.js` pass. - [x] The eight `parallel/test-shadow-realm-*` tests no longer run in CI. --------- Co-authored-by: divybot <divybot@users.noreply.github.com> Co-authored-by: Divy Srivastava <me@littledivy.com>
1 parent eb042fb commit a9bc206

1 file changed

Lines changed: 32 additions & 0 deletions

File tree

tests/node_compat/config.jsonc

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3093,6 +3093,38 @@
30933093
"parallel/test-set-incoming-message-header.js": {},
30943094
"parallel/test-set-process-debug-port.js": {},
30953095
"parallel/test-setproctitle.js": {},
3096+
"parallel/test-shadow-realm-allowed-builtin-modules.js": {
3097+
"ignore": true,
3098+
"reason": "Deno does not expose `ShadowRealm` globally; the spec is still TC39 Stage 2.7"
3099+
},
3100+
"parallel/test-shadow-realm-gc-module.js": {
3101+
"ignore": true,
3102+
"reason": "Deno does not expose `ShadowRealm` globally; the spec is still TC39 Stage 2.7"
3103+
},
3104+
"parallel/test-shadow-realm-gc.js": {
3105+
"ignore": true,
3106+
"reason": "Deno does not expose `ShadowRealm` globally; the spec is still TC39 Stage 2.7"
3107+
},
3108+
"parallel/test-shadow-realm-globals.js": {
3109+
"ignore": true,
3110+
"reason": "Deno does not expose `ShadowRealm` globally; the spec is still TC39 Stage 2.7"
3111+
},
3112+
"parallel/test-shadow-realm-import-value-resolve.js": {
3113+
"ignore": true,
3114+
"reason": "Deno does not expose `ShadowRealm` globally; the spec is still TC39 Stage 2.7"
3115+
},
3116+
"parallel/test-shadow-realm-module.js": {
3117+
"ignore": true,
3118+
"reason": "Deno does not expose `ShadowRealm` globally; the spec is still TC39 Stage 2.7"
3119+
},
3120+
"parallel/test-shadow-realm-prepare-stack-trace.js": {
3121+
"ignore": true,
3122+
"reason": "Deno does not expose `ShadowRealm` globally; the spec is still TC39 Stage 2.7"
3123+
},
3124+
"parallel/test-shadow-realm.js": {
3125+
"ignore": true,
3126+
"reason": "Deno does not expose `ShadowRealm` globally; the spec is still TC39 Stage 2.7"
3127+
},
30963128
"parallel/test-sigint-infinite-loop.js": {},
30973129
"parallel/test-signal-handler-remove-on-exit.js": {},
30983130
"parallel/test-signal-handler.js": {},

0 commit comments

Comments
 (0)