refactor: remove _readWithCancelHandle from Stdin (#33222)

Remove the `_readWithCancelHandle` mechanism -- a cancel-aware read path
for stdin used by `stream_wrap.ts`.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: bartlomieju

ext/io/12_io.js

@@ -5,19 +5,14 @@
 // Thank you! We love Go! <3
 
 import { core, primordials } from "ext:core/mod.js";
-import {
-  op_read_create_cancel_handle,
-  op_read_with_cancel_handle,
-  op_set_raw,
-} from "ext:core/ops";
+import { op_set_raw } from "ext:core/ops";
 const {
   Uint8Array,
   ArrayPrototypePush,
   Symbol,
   TypedArrayPrototypeSubarray,
   TypedArrayPrototypeSet,
   TypedArrayPrototypeGetByteLength,
-  PromisePrototypeThen,
 } = primordials;
 
 import {
@@ -116,8 +111,6 @@ const STDERR_RID = 2;
 const REF = Symbol("REF");
 const UNREF = Symbol("UNREF");
 
-const _readWithCancelHandle = Symbol("_readWithCancelHandle");
-
 class Stdin {
   #rid = STDIN_RID;
   #ref = true;
@@ -141,22 +134,6 @@ class Stdin {
     return nread === 0 ? null : nread;
   }
 
-  [_readWithCancelHandle](p) {
-    const handle = op_read_create_cancel_handle();
-    if (p.length === 0) return { cancelHandle: handle, nread: 0 };
-    this.#opPromise = op_read_with_cancel_handle(this.#rid, handle, p);
-    if (!this.#ref) {
-      core.unrefOpPromise(this.#opPromise);
-    }
-    return {
-      cancelHandle: handle,
-      nread: PromisePrototypeThen(
-        this.#opPromise,
-        (nread) => nread === 0 ? null : nread,
-      ),
-    };
-  }
-
   readSync(p) {
     return readSync(this.#rid, p);
   }
@@ -271,7 +248,6 @@ const stdout = new Stdout();
 const stderr = new Stderr();
 
 export {
-  _readWithCancelHandle,
   read,
   readAll,
   readAllSync,

ext/io/lib.rs

@@ -26,10 +26,8 @@ use deno_core::AsyncRefCell;
 use deno_core::AsyncResult;
 use deno_core::BufMutView;
 use deno_core::BufView;
-use deno_core::CancelFuture;
 use deno_core::CancelHandle;
 use deno_core::CancelTryFuture;
-use deno_core::JsBuffer;
 use deno_core::OpState;
 use deno_core::RcRef;
 use deno_core::Resource;
@@ -212,10 +210,6 @@ fn stdio_fd(fd: i32) -> StdFile {
 
 deno_core::extension!(deno_io,
   deps = [ deno_web ],
-  ops = [
-    op_read_with_cancel_handle,
-    op_read_create_cancel_handle,
-  ],
   esm = [ "12_io.js" ],
   options = {
     stdio: Option<Stdio>,
@@ -1341,65 +1335,6 @@ impl crate::fs::File for StdFileResourceInner {
   }
 }
 
-pub struct ReadCancelResource(Rc<CancelHandle>);
-
-impl ReadCancelResource {
-  pub fn cancel_handle(&self) -> Rc<CancelHandle> {
-    self.0.clone()
-  }
-}
-
-impl Resource for ReadCancelResource {
-  fn name(&self) -> Cow<'_, str> {
-    "readCancel".into()
-  }
-
-  fn close(self: Rc<Self>) {
-    self.0.cancel();
-  }
-}
-
-#[op2(fast)]
-#[smi]
-pub fn op_read_create_cancel_handle(state: &mut OpState) -> u32 {
-  state
-    .resource_table
-    .add(ReadCancelResource(CancelHandle::new_rc()))
-}
-
-#[op2]
-pub async fn op_read_with_cancel_handle(
-  state: Rc<RefCell<OpState>>,
-  #[smi] rid: u32,
-  #[smi] cancel_handle: u32,
-  #[buffer] buf: JsBuffer,
-) -> Result<u32, JsErrorBox> {
-  let (fut, cancel_rc) = {
-    let state = state.borrow();
-    let cancel_handle = state
-      .resource_table
-      .get::<ReadCancelResource>(cancel_handle)
-      .unwrap()
-      .0
-      .clone();
-
-    (
-      FileResource::with_file(&state, rid, |file| {
-        let view = BufMutView::from(buf);
-        Ok(file.read_byob(view))
-      }),
-      cancel_handle,
-    )
-  };
-
-  fut?
-    .or_cancel(cancel_rc)
-    .await
-    .map_err(|_| JsErrorBox::generic("cancelled"))?
-    .map(|(n, _)| n as u32)
-    .map_err(JsErrorBox::from_err)
-}
-
 // override op_print to use the stdout and stderr in the resource table
 #[op2(fast)]
 pub fn op_print(

ext/node/polyfills/internal_binding/stream_wrap.ts

@@ -53,7 +53,6 @@ import {
   providerType,
 } from "ext:deno_node/internal_binding/async_wrap.ts";
 import { codeMap } from "ext:deno_node/internal_binding/uv.ts";
-import { _readWithCancelHandle } from "ext:deno_io/12_io.js";
 import { NodeTypeError } from "ext:deno_node/internal/errors.ts";
 
 export const kUseNativeWrap = Symbol("useNativeWrap");
@@ -385,17 +384,7 @@ export class LibuvStreamWrap extends HandleWrap {
 
     const ridBefore = this[kStreamBaseField]![internalRidSymbol];
     try {
-      if (this[kStreamBaseField]![_readWithCancelHandle]) {
-        const { cancelHandle, nread: p } = this[kStreamBaseField]!
-          [_readWithCancelHandle](buf);
-        if (cancelHandle) {
-          this.cancelHandle = cancelHandle;
-        }
-
-        nread = await p;
-      } else {
-        nread = await this[kStreamBaseField]!.read(buf);
-      }
+      nread = await this[kStreamBaseField]!.read(buf);
     } catch (e) {
       // Try to read again if the underlying stream resource
       // changed. This can happen during TLS upgrades (eg. STARTTLS)