perf(ext/node): replace node: imports with core.loadExtScript for buffer and nextTick (#33862)

bartlomieju · web-flow · commit e481bf74f920 · 2026-05-06T11:39:45.000+02:00
Replace ESM `import` of `node:buffer` and `node:process` (nextTick) in
polyfill files with direct `core.loadExtScript()` calls to the
underlying internal modules. Also simplify `internal/assert.mjs` to
return the assert function directly instead of wrapping in `{ default:
assert }`.
diff --git a/ext/node/polyfills/_brotli.js b/ext/node/polyfills/_brotli.js
@@ -36,7 +36,7 @@ const { zlib: constants } = core.loadExtScript(
 );
 const { TextEncoder } = core.loadExtScript("ext:deno_web/08_text_encoding.js");
 import { Transform } from "node:stream";
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 
 const enc = new TextEncoder();
 const toU8 = (input) => {
diff --git a/ext/node/polyfills/_fs/_fs_read.ts b/ext/node/polyfills/_fs/_fs_read.ts
@@ -3,7 +3,7 @@
 // TODO(petamoriken): enable prefer-primordials for node polyfills
 // deno-lint-ignore-file prefer-primordials
 
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 const {
   denoErrorToNodeError,
   ERR_INVALID_ARG_VALUE,
diff --git a/ext/node/polyfills/_fs/_fs_readdir.ts b/ext/node/polyfills/_fs/_fs_readdir.ts
@@ -12,7 +12,7 @@ import {
   direntFromDeno,
   getValidatedPath,
 } from "ext:deno_node/internal/fs/utils.mjs";
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 const { promisify } = core.loadExtScript("ext:deno_node/internal/util.mjs");
 import { op_fs_read_dir_async, op_fs_read_dir_sync } from "ext:core/ops";
 import { join, relative } from "node:path";
diff --git a/ext/node/polyfills/_http_client.js b/ext/node/polyfills/_http_client.js
@@ -59,7 +59,7 @@ import {
   parseUniqueHeadersOption,
 } from "node:_http_outgoing";
 import httpAgent from "node:_http_agent";
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 import { urlToHttpOptions } from "ext:deno_node/internal/url.ts";
 const { kOutHeaders } = core.loadExtScript("ext:deno_node/internal/http.ts");
 const {
diff --git a/ext/node/polyfills/_http_outgoing.ts b/ext/node/polyfills/_http_outgoing.ts
@@ -6,7 +6,7 @@
 
 import { core } from "ext:core/mod.js";
 import { getDefaultHighWaterMark } from "ext:deno_node/internal/streams/state.js";
-const { default: assert } = core.loadExtScript(
+const assert = core.loadExtScript(
   "ext:deno_node/internal/assert.mjs",
 );
 import EE from "node:events";
@@ -18,7 +18,7 @@ const {
   kOutHeaders,
   utcDate,
 } = core.loadExtScript("ext:deno_node/internal/http.ts");
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 import {
   _checkInvalidHeaderChar as checkInvalidHeaderChar,
   _checkIsHttpToken as checkIsHttpToken,
diff --git a/ext/node/polyfills/_http_server.js b/ext/node/polyfills/_http_server.js
@@ -36,7 +36,7 @@ const {
 } = primordials;
 
 import net from "node:net";
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 import { ok as assert } from "node:assert";
 import {
   _checkInvalidHeaderChar as checkInvalidHeaderChar,
diff --git a/ext/node/polyfills/_process/streams.mjs b/ext/node/polyfills/_process/streams.mjs
@@ -13,7 +13,7 @@ const {
   ObjectPrototypeIsPrototypeOf,
 } = primordials;
 
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 const {
   clearLine,
   clearScreenDown,
diff --git a/ext/node/polyfills/_tls_wrap.js b/ext/node/polyfills/_tls_wrap.js
@@ -12,7 +12,7 @@ const {
   ObjectAssign,
   StringPrototypeReplace,
 } = core.loadExtScript("ext:deno_node/internal/primordials.mjs");
-const { default: assert } = core.loadExtScript(
+const assert = core.loadExtScript(
   "ext:deno_node/internal/assert.mjs",
 );
 import * as net from "node:net";
@@ -22,7 +22,7 @@ import {
 } from "node:_tls_common";
 import { JSStreamSocket } from "ext:deno_node/internal/js_stream_socket.js";
 import { convertALPNProtocols } from "ext:deno_node/internal/tls_common.js";
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 const {
   connResetException,
   ERR_INVALID_ARG_TYPE,
diff --git a/ext/node/polyfills/child_process.ts b/ext/node/polyfills/child_process.ts
@@ -42,7 +42,7 @@ const {
 } = core.loadExtScript("ext:deno_node/internal/errors.ts");
 import { getSystemErrorName, promisify } from "node:util";
 import process from "node:process";
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 const {
   convertToValidSignal,
   kEmptyObject,
diff --git a/ext/node/polyfills/dgram.ts b/ext/node/polyfills/dgram.ts
@@ -24,7 +24,7 @@
 // deno-lint-ignore-file prefer-primordials
 
 import { core } from "ext:core/mod.js";
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 import { EventEmitter } from "node:events";
 import { lookup as defaultLookup } from "node:dns";
 import type {
@@ -68,7 +68,7 @@ const { guessHandleType } = core.loadExtScript(
 const { os } = core.loadExtScript(
   "ext:deno_node/internal_binding/constants.ts",
 );
-import { nextTick } from "node:process";
+const { nextTick } = core.loadExtScript("ext:deno_node/_next_tick.ts");
 import { deprecate } from "node:util";
 import { channel } from "node:diagnostics_channel";
 const { isArrayBufferView } = core.loadExtScript(
diff --git a/ext/node/polyfills/diagnostics_channel.js b/ext/node/polyfills/diagnostics_channel.js
@@ -8,7 +8,7 @@ import { core, primordials } from "ext:core/mod.js";
 const { ERR_INVALID_ARG_TYPE } = core.loadExtScript(
   "ext:deno_node/internal/errors.ts",
 );
-import { nextTick } from "node:process";
+const { nextTick } = core.loadExtScript("ext:deno_node/_next_tick.ts");
 const { validateFunction } = core.loadExtScript(
   "ext:deno_node/internal/validators.mjs",
 );
diff --git a/ext/node/polyfills/fs.ts b/ext/node/polyfills/fs.ts
@@ -83,7 +83,7 @@ import {
   warnOnNonPortableTemplate,
 } from "ext:deno_node/internal/fs/utils.mjs";
 import { glob, globSync } from "ext:deno_node/_fs/_fs_glob.ts";
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 import process from "node:process";
 import { FileHandle } from "ext:deno_node/internal/fs/handle.ts";
 const { isIterable } = core.loadExtScript(
diff --git a/ext/node/polyfills/internal/assert.mjs b/ext/node/polyfills/internal/assert.mjs
@@ -17,7 +17,5 @@ function fail(message) {
 
 assert.fail = fail;
 
-return {
-  default: assert,
-};
+return assert;
 })();
diff --git a/ext/node/polyfills/internal/child_process.ts b/ext/node/polyfills/internal/child_process.ts
@@ -53,7 +53,7 @@ const {
   ERR_MISSING_ARGS,
   ERR_UNKNOWN_SIGNAL,
 } = core.loadExtScript("ext:deno_node/internal/errors.ts");
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 const { FastBuffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 const {
   ERR_IPC_DISCONNECTED,
diff --git a/ext/node/polyfills/internal/console/constructor.mjs b/ext/node/polyfills/internal/console/constructor.mjs
@@ -66,7 +66,7 @@ const {
   validateInteger,
   validateObject,
 } = core.loadExtScript("ext:deno_node/internal/validators.mjs");
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 const { isBuffer } = Buffer;
 const {
   formatWithOptions,
diff --git a/ext/node/polyfills/internal/crypto/certificate.ts b/ext/node/polyfills/internal/crypto/certificate.ts
@@ -1,12 +1,13 @@
 // Copyright 2018-2026 the Deno authors. MIT license.
 // Copyright Joyent, Inc. and Node.js contributors. All rights reserved. MIT license.
 
+import { core } from "ext:core/mod.js";
 import {
   op_node_cert_export_challenge,
   op_node_cert_export_public_key,
   op_node_verify_spkac,
 } from "ext:core/ops";
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 import { getArrayBufferOrView } from "ext:deno_node/internal/crypto/keys.ts";
 
 // The functions contained in this file cover the SPKAC format
diff --git a/ext/node/polyfills/internal/crypto/cipher.ts b/ext/node/polyfills/internal/crypto/cipher.ts
@@ -34,7 +34,7 @@ import {
   op_node_validate_oaep_hash,
 } from "ext:core/ops";
 
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 import process from "node:process";
 import type { TransformOptions } from "ext:deno_node/_stream.d.ts";
 import { Transform } from "node:stream";
diff --git a/ext/node/polyfills/internal/crypto/diffiehellman.ts b/ext/node/polyfills/internal/crypto/diffiehellman.ts
@@ -36,7 +36,7 @@ const {
   validateInt32,
   validateString,
 } = core.loadExtScript("ext:deno_node/internal/validators.mjs");
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 import { deprecate } from "node:util";
 import {
   EllipticCurve,
diff --git a/ext/node/polyfills/internal/crypto/hash.ts b/ext/node/polyfills/internal/crypto/hash.ts
@@ -17,7 +17,7 @@ import {
 } from "ext:core/ops";
 import { core, primordials } from "ext:core/mod.js";
 
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 import { Transform } from "node:stream";
 const {
   forgivingBase64Encode: encodeToBase64,
diff --git a/ext/node/polyfills/internal/crypto/hkdf.ts b/ext/node/polyfills/internal/crypto/hkdf.ts
@@ -42,7 +42,7 @@ const { isKeyObject } = core.loadExtScript(
   "ext:deno_node/internal/crypto/_keys.ts",
 );
 import { getHashes } from "ext:deno_node/internal/crypto/hash.ts";
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 
 // Consume raw bytes for any ArrayBufferView/ArrayBuffer; strings via toBuf.
 function toRawBytes(x: unknown): Buffer {
diff --git a/ext/node/polyfills/internal/crypto/keys.ts b/ext/node/polyfills/internal/crypto/keys.ts
@@ -57,7 +57,7 @@ import type {
   PrivateKeyInput,
   PublicKeyInput,
 } from "ext:deno_node/internal/crypto/types.ts";
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 const {
   isAnyArrayBuffer,
   isArrayBufferView,
diff --git a/ext/node/polyfills/internal/crypto/pbkdf2.ts b/ext/node/polyfills/internal/crypto/pbkdf2.ts
@@ -10,7 +10,7 @@ import {
   op_node_pbkdf2_validate,
 } from "ext:core/ops";
 
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 import { HASH_DATA } from "ext:deno_node/internal/crypto/types.ts";
 const {
   validateFunction,
diff --git a/ext/node/polyfills/internal/crypto/random.ts b/ext/node/polyfills/internal/crypto/random.ts
@@ -35,7 +35,7 @@ const {
   NodeError,
   NodeRangeError,
 } = core.loadExtScript("ext:deno_node/internal/errors.ts");
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 
 export { default as randomBytes } from "ext:deno_node/internal/crypto/_randomBytes.ts";
 export {
diff --git a/ext/node/polyfills/internal/crypto/scrypt.ts b/ext/node/polyfills/internal/crypto/scrypt.ts
@@ -27,7 +27,7 @@ SOFTWARE.
 // deno-lint-ignore-file prefer-primordials
 
 import { core } from "ext:core/mod.js";
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 import { HASH_DATA } from "ext:deno_node/internal/crypto/types.ts";
 import { op_node_scrypt_async, op_node_scrypt_sync } from "ext:core/ops";
 const {
diff --git a/ext/node/polyfills/internal/crypto/sig.ts b/ext/node/polyfills/internal/crypto/sig.ts
@@ -28,7 +28,7 @@ const {
   validateFunction,
   validateString,
 } = core.loadExtScript("ext:deno_node/internal/validators.mjs");
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 import type { WritableOptions } from "ext:deno_node/_stream.d.ts";
 import Writable from "node:_stream_writable";
 import type {
diff --git a/ext/node/polyfills/internal/crypto/util.ts b/ext/node/polyfills/internal/crypto/util.ts
@@ -6,7 +6,7 @@
 
 import { core } from "ext:core/mod.js";
 const { notImplemented } = core.loadExtScript("ext:deno_node/_utils.ts");
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 const {
   ERR_CRYPTO_INVALID_DIGEST,
   ERR_INVALID_ARG_TYPE,
diff --git a/ext/node/polyfills/internal/crypto/x509.ts b/ext/node/polyfills/internal/crypto/x509.ts
@@ -40,7 +40,7 @@ import {
 const { kHandle } = core.loadExtScript(
   "ext:deno_node/internal/crypto/constants.ts",
 );
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 const {
   ERR_INVALID_ARG_TYPE,
   ERR_INVALID_ARG_VALUE,
diff --git a/ext/node/polyfills/internal/fs/streams.mjs b/ext/node/polyfills/internal/fs/streams.mjs
@@ -29,7 +29,7 @@ const {
 } = core.loadExtScript("ext:deno_node/internal/validators.mjs");
 import { errorOrDestroy } from "ext:deno_node/internal/streams/destroy.js";
 import * as fs from "node:fs";
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 import {
   copyObject,
   getOptions,
diff --git a/ext/node/polyfills/internal/fs/utils.mjs b/ext/node/polyfills/internal/fs/utils.mjs
@@ -39,7 +39,7 @@ const {
   Uint8Array,
   Uint8ArrayPrototype,
 } = primordials;
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 const {
   ERR_FS_EISDIR,
   ERR_FS_INVALID_SYMLINK_TYPE,
@@ -72,7 +72,7 @@ const {
 import pathModule from "node:path";
 const kType = Symbol("type");
 const kStats = Symbol("stats");
-const { default: assert } = core.loadExtScript(
+const assert = core.loadExtScript(
   "ext:deno_node/internal/assert.mjs",
 );
 import { lstat, lstatSync } from "ext:deno_node/_fs/_fs_lstat.ts";
diff --git a/ext/node/polyfills/internal/js_stream_socket.js b/ext/node/polyfills/internal/js_stream_socket.js
@@ -18,7 +18,7 @@ const {
   kLastWriteWasAsync,
   streamBaseState,
 } = core.loadExtScript("ext:deno_node/internal_binding/stream_wrap.ts");
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 
 const kCurrentWriteRequest = Symbol("kCurrentWriteRequest");
 const kCurrentShutdownRequest = Symbol("kCurrentShutdownRequest");
diff --git a/ext/node/polyfills/internal/net.ts b/ext/node/polyfills/internal/net.ts
@@ -20,7 +20,7 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 import { core } from "ext:core/mod.js";
 const { uvException } = core.loadExtScript("ext:deno_node/internal/errors.ts");
 const { writeBuffer } = core.loadExtScript(
diff --git a/ext/node/polyfills/internal/stream_base_commons.ts b/ext/node/polyfills/internal/stream_base_commons.ts
@@ -43,7 +43,7 @@ import { getTimerDuration, kTimeout } from "ext:deno_node/internal/timers.mjs";
 import { clearTimeout } from "node:timers";
 import { setUnrefTimeout } from "ext:deno_node/internal/timers.mjs";
 const { codeMap } = core.loadExtScript("ext:deno_node/internal_binding/uv.ts");
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 const { isUint8Array } = core.loadExtScript(
   "ext:deno_node/internal/util/types.ts",
 );
diff --git a/ext/node/polyfills/internal/streams/duplexpair.js b/ext/node/polyfills/internal/streams/duplexpair.js
@@ -4,7 +4,7 @@
 import process from "node:process";
 import { core, primordials } from "ext:core/mod.js";
 import { Duplex } from "node:stream";
-const { default: assert } = core.loadExtScript(
+const assert = core.loadExtScript(
   "ext:deno_node/internal/assert.mjs",
 );
 "use strict";
diff --git a/ext/node/polyfills/internal/streams/fast-utf8-stream.js b/ext/node/polyfills/internal/streams/fast-utf8-stream.js
@@ -5,7 +5,7 @@
 // Copyright (c) 2017 Matteo Collina
 
 import { core, primordials } from "ext:core/mod.js";
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 import EventEmitter from "node:events";
 import * as fs from "node:fs";
 import * as path from "node:path";
diff --git a/ext/node/polyfills/internal/streams/from.js b/ext/node/polyfills/internal/streams/from.js
@@ -3,7 +3,7 @@
 
 import process from "node:process";
 import { core, primordials } from "ext:core/mod.js";
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 const _mod1 = core.loadExtScript("ext:deno_node/internal/errors.ts");
 
 const {
diff --git a/ext/node/polyfills/internal/streams/readable.js b/ext/node/polyfills/internal/streams/readable.js
@@ -8,7 +8,7 @@ import {
   prependListener,
   Stream,
 } from "ext:deno_node/internal/streams/legacy.js";
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 import { addAbortSignal } from "ext:deno_node/internal/streams/add-abort-signal.js";
 import eos from "ext:deno_node/internal/streams/end-of-stream.js";
 import destroyImpl from "ext:deno_node/internal/streams/destroy.js";
diff --git a/ext/node/polyfills/internal/streams/writable.js b/ext/node/polyfills/internal/streams/writable.js
@@ -5,7 +5,7 @@ import process from "node:process";
 import { core, primordials } from "ext:core/mod.js";
 import EE from "node:events";
 import _mod1 from "ext:deno_node/internal/streams/legacy.js";
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 import destroyImpl from "ext:deno_node/internal/streams/destroy.js";
 import eos from "ext:deno_node/internal/streams/end-of-stream.js";
 import { addAbortSignal } from "ext:deno_node/internal/streams/add-abort-signal.js";
diff --git a/ext/node/polyfills/internal/tls_common.js b/ext/node/polyfills/internal/tls_common.js
@@ -6,7 +6,7 @@
 
 // deno-lint-ignore-file prefer-primordials
 
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 import { core, primordials } from "ext:core/mod.js";
 const { codes } = core.loadExtScript("ext:deno_node/internal/errors.ts");
 const {
diff --git a/ext/node/polyfills/internal/util/comparisons.ts b/ext/node/polyfills/internal/util/comparisons.ts
@@ -3,7 +3,7 @@
 
 // deno-lint-ignore-file
 import { core, primordials } from "ext:core/mod.js";
-import { Buffer } from "node:buffer";
+const { Buffer } = core.loadExtScript("ext:deno_node/internal/buffer.mjs");
 const {
   getOwnNonIndexProperties,
   ONLY_ENUMERABLE,
diff --git a/ext/node/polyfills/internal/webstreams/adapters.js b/ext/node/polyfills/internal/webstreams/adapters.js
diff --git a/ext/node/polyfills/internal_binding/_timingSafeEqual.ts b/ext/node/polyfills/internal_binding/_timingSafeEqual.ts
diff --git a/ext/node/polyfills/internal_binding/http_parser.ts b/ext/node/polyfills/internal_binding/http_parser.ts
diff --git a/ext/node/polyfills/net.ts b/ext/node/polyfills/net.ts
diff --git a/ext/node/polyfills/querystring.js b/ext/node/polyfills/querystring.js
diff --git a/ext/node/polyfills/stream/consumers.js b/ext/node/polyfills/stream/consumers.js
diff --git a/ext/node/polyfills/v8.ts b/ext/node/polyfills/v8.ts
diff --git a/ext/node/polyfills/vm.js b/ext/node/polyfills/vm.js
diff --git a/ext/node/polyfills/zlib.js b/ext/node/polyfills/zlib.js
