fix(ext/node): implement displayErrors for vm scripts (#33942)

## Summary

- Implements the `displayErrors` option for vm scripts in
`ext/node/ops/vm.rs`
- When `displayErrors` is true (the default), decorates the thrown
error's `stack` property with source location info —
`filename:line\nsource_line\narrow\n\n` — prepended to the existing
stack, matching Node.js behaviour
- Adds `validateObject(options, "options")` to `vm.compileFunction` so
the test's invalid-options assertions throw with the expected
`ERR_INVALID_ARG_TYPE` message
- Enables `parallel/test-vm-basic.js` in
`tests/node_compat/config.jsonc`

Closes denoland/orchid#3

Diff is fully self-contained: 51 lines in `ext/node/ops/vm.rs` + 1 line
in `ext/node/polyfills/vm.js` + 1 line in
`tests/node_compat/config.jsonc`. No follow-up needed; everything the
enabled test requires is in this PR.

Co-authored-by: Divy Srivastava <me@littledivy.com>

Author: divybot

ext/node/ops/vm.rs

@@ -179,7 +179,7 @@ impl ContextifyScript {
     scope: &mut v8::PinScope<'s, 'i>,
     context: v8::Local<'s, v8::Context>,
     timeout: i64,
-    _display_errors: bool,
+    display_errors: bool,
     _break_on_sigint: bool,
     microtask_queue: Option<&v8::MicrotaskQueue>,
   ) -> Option<v8::Local<'s, v8::Value>> {
@@ -252,6 +252,55 @@ impl ContextifyScript {
     }
 
     if scope.has_caught() {
+      // When displayErrors is true (the default), decorate the error's stack
+      // with source location info prepended, matching Node.js behaviour.
+      if display_errors
+        && !scope.has_terminated()
+        && let Some(msg) = scope.message()
+        && let Some(exception) = scope.exception()
+        && let Ok(exc_obj) = v8::Local::<v8::Object>::try_from(exception)
+      {
+        let filename = if let Some(v) = msg.get_script_resource_name(scope) {
+          if let Some(s) = v.to_string(scope) {
+            s.to_rust_string_lossy(scope)
+          } else {
+            String::new()
+          }
+        } else {
+          String::new()
+        };
+        let line_number = msg.get_line_number(scope).unwrap_or(1);
+        let source_line = if let Some(s) = msg.get_source_line(scope) {
+          s.to_rust_string_lossy(scope)
+        } else {
+          String::new()
+        };
+        if !filename.is_empty() {
+          let start_col = msg.get_start_column();
+          let arrow = format!("{}^", " ".repeat(start_col));
+          let preamble = format!(
+            "{}:{}\n{}\n{}\n\n",
+            filename, line_number, source_line, arrow
+          );
+
+          let stack_key =
+            v8::String::new_external_onebyte_static(scope, b"stack").unwrap();
+          let current_stack =
+            if let Some(v) = exc_obj.get(scope, stack_key.into()) {
+              if let Some(s) = v.to_string(scope) {
+                s.to_rust_string_lossy(scope)
+              } else {
+                String::new()
+              }
+            } else {
+              String::new()
+            };
+          let new_stack = format!("{}{}", preamble, current_stack);
+          if let Some(new_stack_str) = v8::String::new(scope, &new_stack) {
+            exc_obj.set(scope, stack_key.into(), new_stack_str.into());
+          }
+        }
+      }
       // If there was an exception thrown during script execution, re-throw it.
       if !scope.has_terminated() {
         scope.rethrow();

ext/node/polyfills/vm.js

@@ -356,6 +356,7 @@ function compileFunction(code, params, options = { __proto__: null }) {
   if (params !== undefined) {
     validateStringArray(params, "params");
   }
+  validateObject(options, "options");
   const {
     filename = "",
     columnOffset = 0,

tests/node_compat/config.jsonc

@@ -3640,6 +3640,7 @@
     "parallel/test-vm-access-process-env.js": {},
     "parallel/test-vm-api-handles-getter-errors.js": {},
     "parallel/test-vm-attributes-property-not-on-sandbox.js": {},
+    "parallel/test-vm-basic.js": {},
     "parallel/test-vm-codegen.js": {},
     "parallel/test-vm-context-async-script.js": {},
     "parallel/test-vm-context-property-forwarding.js": {},