Skip to content

chore(ci): use deno check instead of deno cache#136

Merged
kt3k merged 2 commits intodenoland:mainfrom
uki00a:use-deno-check-instead-of-cache
Sep 13, 2022
Merged

chore(ci): use deno check instead of deno cache#136
kt3k merged 2 commits intodenoland:mainfrom
uki00a:use-deno-check-instead-of-cache

Conversation

@uki00a
Copy link
Copy Markdown
Contributor

@uki00a uki00a commented Sep 12, 2022

deno cache no longer performs type checking by default. This replaces that with deno check to detect type errors in CI

@@ -37,7 +37,8 @@ jobs:
run: deno lint

- name: Typecheck
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deno v1.20.1 does not seem to support deno check yet

deno-version: ${{ matrix.deno == 'old' && '1.20.1' || (matrix.deno == 'stable' && '1.x' || matrix.deno) }}

Copy link
Copy Markdown
Contributor

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 095cfdd into denoland:main Sep 13, 2022
@uki00a uki00a deleted the use-deno-check-instead-of-cache branch September 13, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants