feat(deploy): push initial deployment to prod#158
Merged
lucab merged 2 commits intodenoland:mainfrom Jun 13, 2023
Merged
Conversation
This tweaks `deploy` behavior on empty projects, pushing the initial deployment to prod and telling the user about futher updates requiring `--prod` flag usage. It also enhances the final status message in order to record which environment got updated (production or preview).
|
|
satyarohith
reviewed
Jun 12, 2023
|
|
||
| if (!project!.hasProductionDeployment) { | ||
| wait("").start().info( | ||
| "Empty project detected, automatically pushing initial deployment to production (use --prod for further updates).", |
Contributor
There was a problem hiding this comment.
We can't make this assumption as there can be existing deployments in a project without productionDeployment being set. We need to rewrite this so that we first fetch deployments for a project and then check if deployments.is_empty()
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback, updated the logic that way.
This was referenced Jun 13, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tweaks
deploybehavior on empty projects, pushing the initial deployment to prod and telling the user about futher updates requiring--prodflag usage.It also enhances the final status message in order to record which environment got updated (production or preview).