fix: set accept: application/x-ndjson in fetching live logs#194
Merged
magurotuna merged 1 commit intodenoland:mainfrom Nov 17, 2023
Merged
fix: set accept: application/x-ndjson in fetching live logs#194magurotuna merged 1 commit intodenoland:mainfrom
accept: application/x-ndjson in fetching live logs#194magurotuna merged 1 commit intodenoland:mainfrom
Conversation
arnauorriols
approved these changes
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #188
This commit sets
accept: application/x-ndjsonheader when fetching live logs.The backend API returns newline-delimited JSON in case of
accept: application/x-ndjsonOR no accept header with the priority ofapplication/jsonbeing higher thanapplication/x-ndjson. In other words, it returns pure JSON response only when the accept header is present such thatapplication/jsonhas higher precedence thanapplication/x-ndjson. So in general it defaults to newline-delimited JSON, but we got this issue because all API calls made by deployctl setaccept: application/jsonexplicitly.