fix: use 'host' instead of 'hostname' for --allow-net docs#3036
Merged
Conversation
The --allow-net flag accepts hosts (hostname or IP, optionally with a port), not just hostnames. Updated terminology and definition to reflect this. Closes #2702 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lunadogbot
approved these changes
May 13, 2026
Contributor
lunadogbot
left a comment
lunadogbot
left a comment
There was a problem hiding this comment.
Terminology change is correct — --allow-net accepts host[:port] and the existing examples on lines 271/274 already use ports. The <HOST> placeholder is consistent across both --allow-net and --deny-net. Closes #2702.
- nit:
last_modified: 2026-03-26in the frontmatter isn't bumped; small fix but the page changed.
Contributor
|
@bartlomieju this is ready to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--allow-netterminology from "IP addresses or hostnames" to "hosts" (hostname or IP, optionally with a port)<IP_OR_HOSTNAME>to<HOST>for both--allow-netand--deny-netCloses #2702
Test plan
🤖 Generated with Claude Code