Skip to content

docs: document deno upgrade pr (2.8)#3087

Merged
bartlomieju merged 2 commits into
denoland:2.8from
lunadogbot:docs/2.8-upgrade-pr
May 20, 2026
Merged

docs: document deno upgrade pr (2.8)#3087
bartlomieju merged 2 commits into
denoland:2.8from
lunadogbot:docs/2.8-upgrade-pr

Conversation

@lunadogbot
Copy link
Copy Markdown
Contributor

Summary

Documents the new deno upgrade pr <number> subcommand shipping in Deno 2.8 (denoland/deno#33252). It downloads the binary built by CI for a given denoland/deno PR via the gh CLI and installs it, optionally to a path with --output.

  • New "Install a build from a pull request" section in runtime/reference/cli/upgrade.md.
  • Notes the gh CLI prerequisite, #-prefix tolerance, the --output/--dry-run interactions, and the {profile}-{os}-{arch}-deno artifact-naming scheme.

Test plan

  • deno task serve — section renders.

Adds a section to upgrade.md describing the new \`deno upgrade pr\`
subcommand which installs the binary built by CI for a specific
denoland/deno PR. Covers the basic usage, the \`--output\` and
\`--dry-run\` interactions, the artifact-naming scheme, and the gh CLI
prerequisite.

Refs denoland/deno#33252
@crowlKats crowlKats changed the base branch from main to 2.8 May 5, 2026 11:43
Copy link
Copy Markdown
Contributor

@fibibot fibibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new deno upgrade pr <number> section matches denoland/deno#33252: the examples use the accepted pr subcommand shape, --output and --dry-run are parsed before pr, and the gh/artifact description matches the implementation. No checks are reported on this head, so holding approval until CI is green.

  • nit: last_modified: 2026-03-05 should be bumped for this content addition.
  • nit: Numeric prefix is also accepted is a little off; this example is accepting a # prefix.

Copy link
Copy Markdown
Contributor

@fibibot fibibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting this. The command behavior matches denoland/deno#33252 and the current cli/tools/upgrade.rs implementation, but I think this needs one docs-policy fix before merge:

  • runtime/reference/cli/upgrade.md has last_modified: 2026-03-05 unchanged while this PR adds a substantive new section. Repo policy asks substantive content changes to bump last_modified, so please update it.
  • While touching it, please also change the comment above deno upgrade pr '#12345' from "Numeric prefix is also accepted" to something like "A # prefix is also accepted". The parser strips #; it is not a numeric prefix.\n\nI did not find a factual issue with the deno upgrade pr behavior itself.

@bartlomieju bartlomieju force-pushed the docs/2.8-upgrade-pr branch from d8dd14e to 559ad2b Compare May 20, 2026 13:57
@bartlomieju bartlomieju merged commit 0c203ec into denoland:2.8 May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants