docs: fix deno create page to require jsr:/npm: prefix#3108
Merged
Conversation
The page claimed unprefixed package names default to JSR, but the CLI errors out with `Missing 'jsr:' or 'npm:' prefix.` when invoked without a prefix or `--jsr` / `--npm` flag. Update the description, examples, and `--jsr` flag annotation to match actual behavior. Closes #3061
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
deno createpage claimed unprefixed package names default to JSR, but on Deno 2.7.14 the CLI errors out withMissing 'jsr:' or 'npm:' prefix.for any unprefixed argument (e.g.deno create @fresh/init, the page's own example, fails). A prefix (jsr:/npm:) or flag (--jsr/--npm) is required.This brings the docs in line with current CLI behavior:
deno create @fresh/init→deno create jsr:@fresh/init, including the-- --forcevariant and the inline@my-scope/my-templatereference in the "How it works" section).(default)annotation from the--jsrflag — there is no default.If the CLI later changes to actually default to JSR, the docs can be reverted to match — that's a runtime change tracked elsewhere.
Closes #3061
Closes bartlomieju/orchid-inbox#49
cc @bartlomieju
Test plan
deno create @fresh/initagainstdenoland/deno:latest(2.7.14) errors withMissing 'jsr:' or 'npm:' prefix.— matches the updated docs.deno create jsr:@fresh/initanddeno create --jsr @fresh/initproceed past the prefix check.